Summary: | [WebIDL] Eagerly allocate element wrappers onto a butterfly storage of a static NodeList | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||
Component: | Bindings | Assignee: | Alexey Shvayka <ashvayka> | ||||
Status: | REOPENED --- | ||||||
Severity: | Normal | CC: | cdumez, commit-queue, darin, esprehn+autocc, ews-watchlist, ggaren, kangil.han, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 218849, 244444, 245151 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Alexey Shvayka
2021-12-20 17:38:50 PST
Created attachment 448520 [details]
WIP
Comment on attachment 448520 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=448520&action=review > Source/JavaScriptCore/runtime/JSTypeInfo.h:113 > + bool getOwnPropertySlotByIndexIsWrongAboutReadOnly() const { return isSetOnFlags2<GetOwnPropertySlotByIndexIsWrongAboutReadOnly>(); } I'd suggest a name that describes what is true rather than what is false. Maybe something like "IndexedPropertiesAreReadOnly" or "PutByIndexOverrideWillProhibitWrites" or something like that. Pull request: https://github.com/WebKit/WebKit/pull/2915 Committed 253834@main (e0c79898e6c5): <https://commits.webkit.org/253834@main> Reviewed commits have been landed. Closing PR #2915 and removing active labels. Re-opened since this is blocked by bug 244444 Pull request: https://github.com/WebKit/WebKit/pull/3786 Committed 253946@main (9d5bc2bbab71): <https://commits.webkit.org/253946@main> Reviewed commits have been landed. Closing PR #3786 and removing active labels. Re-opening for pull request https://github.com/WebKit/WebKit/pull/3902 Committed 254036@main (de4790b17831): <https://commits.webkit.org/254036@main> Reviewed commits have been landed. Closing PR #3902 and removing active labels. Re-opened since this is blocked by bug 245151 Before re-landing this check to make sure we don’t reintroduce bug 244900. |