Summary: | Roll ANGLE to aabfe8747d 12-17-2021 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kyle Piddington <kpiddington> | ||||||||
Component: | ANGLE | Assignee: | Kyle Piddington <kpiddington> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | annulen, dino, ews-watchlist, gyuyoung.kim, kbr, kkinnunen, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 234391 | ||||||||||
Attachments: |
|
Description
Kyle Piddington
2021-12-20 12:46:27 PST
Created attachment 447623 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 447623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447623&action=review Great to see the progress reducing the diffs from upstream. r+ from me; most carefully reviewed the Metal backend changes, and changes.diff. A couple of small questions; feel free to move ahead without re-review. > Source/ThirdParty/ANGLE/ChangeLog:8 > + * ANGLE.plist: Suggest trimming ChangeLog as before. > Source/ThirdParty/ANGLE/changes.diff:922 > + switch_data += "#if (TARGET_OS_OSX && (__MAC_OS_X_VERSION_MAX_ALLOWED >= 110000))\n" Could you double-check whether these ifdefs were properly upstreamed? Thought these diffs should have been resolved already. Created attachment 448311 [details]
Patch
Comment on attachment 448311 [details]
Patch
Looks good to me - r+.
I most carefully reviewed changes.diff and all the changes under src/libANGLE/renderer/metal.
Created attachment 448411 [details]
Patch for landing
Committed r287652 (245750@main): <https://commits.webkit.org/245750@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448411 [details]. |