Bug 23444

Summary: Add OptionElement/OptionGroupElement abstraction
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: XMLAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: staikos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 20393    
Attachments:
Description Flags
Initial patch
none
Updated patch staikos: review+

Nikolas Zimmermann
Reported 2009-01-20 18:37:51 PST
Refactor some functionality living in HTMLOptionElement/HTMLOptGroupElement needed by RenderMenuList/RenderListBox, to allow reusing these render classes later on for WMLOption/OptGroupElement.
Attachments
Initial patch (26.91 KB, patch)
2009-01-20 18:39 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Updated patch (26.85 KB, patch)
2009-01-20 19:41 PST, Nikolas Zimmermann 		staikos: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2009-01-20 18:39:33 PST
Created attachment 26881 [details] Initial patch
Nikolas Zimmermann
Comment 2 2009-01-20 19:41:18 PST
Created attachment 26882 [details] Updated patch No regressions, previous patch had a problem in an editing/pasteboard test.
Nikolas Zimmermann
Comment 3 2009-01-21 08:44:48 PST
Landed in r40085.
Note You need to log in before you can comment on or make changes to this bug.