Bug 234436

Summary:	REGRESSION (r287124?): ASSERTION FAILED: addResult3.isNewEntry in WTR::WebNotificationProvider::showWebNotification()
Product:	WebKit	Reporter:	Ryan Haddad <ryanhaddad>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED DUPLICATE
Severity:	Normal	CC:	beidson, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=234370

Ryan Haddad

Reported 2021-12-17 10:19:58 PST

imported/w3c/web-platform-tests/notifications/lang.html is flakily failing the following assert on macOS debug bots ASSERTION FAILED: addResult3.isNewEntry /Volumes/Data/worker/bigsur-debug/build/Tools/WebKitTestRunner/WebNotificationProvider.cpp(100) : void WTR::WebNotificationProvider::showWebNotification(WKPageRef, WKNotificationRef) 1 0x1052fd6ec WTFCrash 2 0x10494a580 void () block_pointer std::__1::exchange<void () block_pointer, std::nullptr_t>(void () block_pointer&, std::nullptr_t&&) 3 0x104a238fc WTR::WebNotificationProvider::showWebNotification(OpaqueWKPage const*, OpaqueWKNotification const*) 4 0x104a23618 WTR::showWebNotification(OpaqueWKPage const*, OpaqueWKNotification const*, void const*) 5 0x10fddc604 WebKit::WebNotificationProvider::show(WebKit::WebPageProxy&, WebKit::WebNotification&) 6 0x10fdda04c WebKit::WebNotificationManagerProxy::show(WebKit::WebPageProxy*, WebCore::NotificationData const&) 7 0x10faf70c4 WebKit::WebPageProxy::showNotification(WebCore::NotificationData const&) 8 0x10fdd9910 WebKit::WebNotificationManagerMessageHandler::showNotification(WebCore::NotificationData const&) 9 0x10e68a7a4 void IPC::callMemberFunctionImpl<WebKit::NotificationManagerMessageHandler, void (WebKit::NotificationManagerMessageHandler::*)(WebCore::NotificationData const&), std::__1::tuple<WebCore::NotificationData>, 0ul>(WebKit::NotificationManagerMessageHandler*, void (WebKit::NotificationManagerMessageHandler::*)(WebCore::NotificationData const&), std::__1::tuple<WebCore::NotificationData>&&, std::__1::integer_sequence<unsigned long, 0ul>) 10 0x10e689620 void IPC::callMemberFunction<WebKit::NotificationManagerMessageHandler, void (WebKit::NotificationManagerMessageHandler::*)(WebCore::NotificationData const&), std::__1::tuple<WebCore::NotificationData>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<WebCore::NotificationData>&&, WebKit::NotificationManagerMessageHandler*, void (WebKit::NotificationManagerMessageHandler::*)(WebCore::NotificationData const&)) 11 0x10e688080 void IPC::handleMessage<Messages::NotificationManagerMessageHandler::ShowNotification, WebKit::NotificationManagerMessageHandler, void (WebKit::NotificationManagerMessageHandler::*)(WebCore::NotificationData const&)>(IPC::Connection&, IPC::Decoder&, WebKit::NotificationManagerMessageHandler*, void (WebKit::NotificationManagerMessageHandler::*)(WebCore::NotificationData const&)) 12 0x10e687c68 WebKit::NotificationManagerMessageHandler::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 13 0x10f44c2c0 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 14 0x10f870084 WebKit::AuxiliaryProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) 15 0x10fb2472c WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 16 0x10f4072f4 IPC::Connection::dispatchMessage(IPC::Decoder&) 17 0x10f407a10 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 18 0x10f4063c4 IPC::Connection::dispatchIncomingMessages() 19 0x10f4279e0 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()() 20 0x10f4278e8 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14, void>::call() 21 0x105327f58 WTF::Function<void ()>::operator()() const 22 0x1053b89e4 WTF::RunLoop::performWork() 23 0x1053bd7b0 WTF::RunLoop::performWork(void*) 24 0x188b72a84 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 25 0x188b729d0 __CFRunLoopDoSource0 26 0x188b726bc __CFRunLoopDoSources0 27 0x188b71044 __CFRunLoopRun 28 0x188b70598 CFRunLoopRunSpecific 29 0x18991a638 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 30 0x1049b4e08 WTR::TestController::platformRunUntil(bool&, WTF::Seconds) 31 0x104968684 WTR::TestController::runUntil(bool&, WTF::Seconds) https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fnotifications%2Flang.html

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-12-17 10:20:13 PST

<rdar://problem/86639831>

Ryan Haddad

Comment 2 2021-12-17 10:59:01 PST

It looks like this might be related to https://trac.webkit.org/changeset/287124/webkit

Ryan Haddad

Comment 3 2021-12-17 15:39:46 PST

Also appearing with imported/w3c/web-platform-tests/wasm/serialization/module/serialization-via-notifications-api.any.html https://results.webkit.org/?suite=layout-tests&test=imported/w3c/web-platform-tests/wasm/serialization/module/serialization-via-notifications-api.any.html

Ryan Haddad

Comment 4 2021-12-22 14:04:54 PST

*** This bug has been marked as a duplicate of bug 234534 ***

Note You need to log in before you can comment on or make changes to this bug.