Bug 234411

Summary: Add custom copy() method for Ref<T> to CrossThreadCopier
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sihui Liu
Reported 2021-12-16 17:24:56 PST
...
Attachments
Patch (12.46 KB, patch)
2021-12-16 20:49 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2021-12-16 20:49:07 PST
Created attachment 447417 [details] Patch
EWS
Comment 2 2021-12-17 14:26:27 PST
Committed r287207 (245374@main): <https://commits.webkit.org/245374@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447417 [details].
Radar WebKit Bug Importer
Comment 3 2021-12-17 14:27:19 PST
<rdar://problem/86650725>
Darin Adler
Comment 4 2021-12-17 14:55:38 PST
Comment on attachment 447417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447417&action=review > Source/WTF/wtf/CrossThreadCopier.h:58 > + typedef T Type; Reminds me that in newer code we’d love to use "using" rather than typedef. > Source/WTF/wtf/CrossThreadCopier.h:107 > + typedef Ref<T> Type; Like here too. > Source/WTF/wtf/CrossThreadCopier.h:111 > + static Type copy(const Type& ref) > + { > + return ref; > + } I probably would write these as one-liners.
Note You need to log in before you can comment on or make changes to this bug.