Bug 234410
| Summary: | REGRESSION (r286944?): web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click tests have become flaky failures | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | New Bugs | Assignee: | youenn fablet <youennf> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jenner, Morningstar, rackler, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=239546 https://bugs.webkit.org/show_bug.cgi?id=238469 |
||
Ryan Haddad
The following two tests have become flaky failures on iOS and macOS, both having an unexpected "+Download size: 0." appear in their diffs.
imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html
imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Ftext-level-semantics%2Fthe-a-element%2Fa-download-click-404.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Ftext-level-semantics%2Fthe-a-element%2Fa-download-click.html
The change "Fix ServiceWorker downloads" (https://trac.webkit.org/changeset/286944/webkit) landed a few revisions before the first failure, and it added "test runner API to log the total download size", so it seems related.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/86608023>
Ryan Haddad
Same with https://results.webkit.org/?suite=layout-tests&test=imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_allow_downloads.tentative.html
Ryan Haddad
Also with https://results.webkit.org/?suite=layout-tests&test=http%2Fwpt%2Fhtml%2Fsemantics%2Ftext-level-semantics%2Fthe-a-element%2Fa-download-click-404.html
Robert Jenner
Added expectations for all of these tests. We only initially observed the following two having a negative impact on EWS:
imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_allow_downloads.tentative.ht'
However, since these are all flaky on OpenSource I'm sure the other tests are probably also causing issues on EWS.
Expectations added here:
https://trac.webkit.org/changeset/288380/webkit
Ryan Haddad
*** Bug 238469 has been marked as a duplicate of this bug. ***
Ryan Haddad
*** Bug 239546 has been marked as a duplicate of this bug. ***
Ryan Haddad
From dupes, this also affects
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-download-click.html
mported/w3c/web-platform-tests/fetch/metadata/download.https.sub.html
youenn fablet
Pull request: https://github.com/WebKit/WebKit/pull/1723
EWS
Committed 251789@main (765fc0d01283): <https://commits.webkit.org/251789@main>
Reviewed commits have been landed. Closing PR #1723 and removing active labels.