| Summary: | [JSC] only emit pointer validation for ARM64E | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Caitlin Potter (:caitp) <caitp> | ||||||
| Component: | New Bugs | Assignee: | Caitlin Potter (:caitp) <caitp> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Caitlin Potter (:caitp)
2021-12-16 11:55:24 PST
Created attachment 447378 [details]
Patch
Comment on attachment 447378 [details]
Patch
r=me if EWS is green.
Probably need to have UNUSED_PARAM for parameters.
Comment on attachment 447378 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447378&action=review > Source/JavaScriptCore/ChangeLog:3 > + [JSC] only emit save/restore register for JIT thunks on ARM64 A better description is “Only emit pointer validation for ARM64E.” > Source/JavaScriptCore/jit/ThunkGenerators.cpp:163 > +#endif You’ll need to add UNUSED_PARAM for the arguments that are not used for non-ARM64E ports. Comment on attachment 447378 [details]
Patch
Oops, didn’t mean to negate Yusuke’s r+. But please apply the fixes.
(In reply to Mark Lam from comment #3) > Comment on attachment 447378 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447378&action=review > > > Source/JavaScriptCore/ChangeLog:3 > > + [JSC] only emit save/restore register for JIT thunks on ARM64 > > A better description is “Only emit pointer validation for ARM64E.” > > > Source/JavaScriptCore/jit/ThunkGenerators.cpp:163 > > +#endif > > You’ll need to add UNUSED_PARAM for the arguments that are not used for > non-ARM64E ports. Done and done, just waiting on EWS Created attachment 447382 [details]
Patch for landing
Committed r287154 (245332@main): <https://commits.webkit.org/245332@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447382 [details]. |