Bug 234402

Summary: [JSC] only emit pointer validation for ARM64E
Product: WebKit Reporter: Caitlin Potter (:caitp) <caitp>
Component: New BugsAssignee: Caitlin Potter (:caitp) <caitp>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch for landing none

Caitlin Potter (:caitp)
Reported 2021-12-16 11:55:24 PST
[JSC] only emit save/restore register for JIT thunks on ARM64
Attachments
Patch (1.56 KB, patch)
2021-12-16 11:58 PST, Caitlin Potter (:caitp) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (1.77 KB, patch)
2021-12-16 12:23 PST, Caitlin Potter (:caitp) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Caitlin Potter (:caitp)
Comment 1 2021-12-16 11:58:13 PST
Created attachment 447378 [details] Patch
Yusuke Suzuki
Comment 2 2021-12-16 12:02:49 PST
Comment on attachment 447378 [details] Patch r=me if EWS is green. Probably need to have UNUSED_PARAM for parameters.
Mark Lam
Comment 3 2021-12-16 12:04:45 PST
Comment on attachment 447378 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447378&action=review > Source/JavaScriptCore/ChangeLog:3 > + [JSC] only emit save/restore register for JIT thunks on ARM64 A better description is “Only emit pointer validation for ARM64E.” > Source/JavaScriptCore/jit/ThunkGenerators.cpp:163 > +#endif You’ll need to add UNUSED_PARAM for the arguments that are not used for non-ARM64E ports.
Mark Lam
Comment 4 2021-12-16 12:06:02 PST
Comment on attachment 447378 [details] Patch Oops, didn’t mean to negate Yusuke’s r+. But please apply the fixes.
Caitlin Potter (:caitp)
Comment 5 2021-12-16 12:11:22 PST
(In reply to Mark Lam from comment #3) > Comment on attachment 447378 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447378&action=review > > > Source/JavaScriptCore/ChangeLog:3 > > + [JSC] only emit save/restore register for JIT thunks on ARM64 > > A better description is “Only emit pointer validation for ARM64E.” > > > Source/JavaScriptCore/jit/ThunkGenerators.cpp:163 > > +#endif > > You’ll need to add UNUSED_PARAM for the arguments that are not used for > non-ARM64E ports. Done and done, just waiting on EWS
Caitlin Potter (:caitp)
Comment 6 2021-12-16 12:23:29 PST
Created attachment 447382 [details] Patch for landing
EWS
Comment 7 2021-12-16 13:07:00 PST
Committed r287154 (245332@main): <https://commits.webkit.org/245332@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447382 [details].
Radar WebKit Bug Importer
Comment 8 2021-12-16 13:08:17 PST
<rdar://problem/86591795>
Note You need to log in before you can comment on or make changes to this bug.