Bug 234396

Summary: Rename forEachFrameFromMainFrame to forEachFrame
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, ggaren, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 23424    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2021-12-16 09:54:17 PST
Follow-up to Bug 234324: Darin and Simon: "I agree with Simon: The core functions themselves need not mention the "main frame". They iterate all frames and all documents. The role of the main frame is an unimportant implementation detail that should not be in the function names. We should immediately rename forEachFrameFromMainFrame to just forEachFrame. The odd function out is forEachDocumentFromMainFrame, and it’s something we should intend to remove (see below)." This patch does that renaming.
Attachments
Patch (2.72 KB, patch)
2021-12-16 10:03 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-12-16 09:55:35 PST
<rdar://problem/86581926>
Brent Fulgham
Comment 2 2021-12-16 10:03:13 PST
Created attachment 447367 [details] Patch
Geoffrey Garen
Comment 3 2021-12-16 10:33:54 PST
Comment on attachment 447367 [details] Patch r=me
EWS
Comment 4 2021-12-16 11:25:00 PST
Committed r287147 (245330@main): <https://commits.webkit.org/245330@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447367 [details].
Note You need to log in before you can comment on or make changes to this bug.