Bug 234396

Summary: Rename forEachFrameFromMainFrame to forEachFrame
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, ggaren, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 23424    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Brent Fulgham 2021-12-16 09:54:17 PST 
Follow-up to Bug 234324:

Darin and Simon:
"I agree with Simon: The core functions themselves need not mention the "main frame". They iterate all frames and all documents. The role of the main frame is an unimportant implementation detail that should not be in the function names.

We should immediately rename forEachFrameFromMainFrame to just forEachFrame. The odd function out is forEachDocumentFromMainFrame, and it’s something we should intend to remove (see below)."

This patch does that renaming.
Comment 1 Radar WebKit Bug Importer 2021-12-16 09:55:35 PST 
<rdar://problem/86581926>
Comment 2 Brent Fulgham 2021-12-16 10:03:13 PST 
Created attachment 447367 [details]
Patch
Comment 3 Geoffrey Garen 2021-12-16 10:33:54 PST 
Comment on attachment 447367 [details]
Patch

r=me
Comment 4 EWS 2021-12-16 11:25:00 PST 
Committed r287147 (245330@main): <https://commits.webkit.org/245330@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447367 [details].