Bug 234375 – null ptr deref in WebCore::findPlaceForCounter

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Gabriel Nava Marino]

Since parentOrPseudoHostElement can return a nullptr, we need to check for that before trying to access the renderer() of the Element object it returns.

[Gabriel Nava Marino]

<rdar://problem/86518846>

[Gabriel Nava Marino]

Created attachment 447305 [details]
Patch

[zalan]

Comment on attachment 447305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447305&action=review

> Source/WebCore/ChangeLog:11
> +        Since parentOrPseudoHostElement can return a nullptr, we need to check for nullptr before trying to
> +        access the renderer() of the Element pointer it returns.

Could you explain why parentOrPseudoHostElement() returns nullptr in here?

> Source/WebCore/rendering/RenderCounter.cpp:315
> +                        auto parent = parentOrPseudoHostElement(*currentRenderer);

I'd write it like auto* parent = parentOrPseudoHostElement(*currentRenderer);

[Gabriel Nava Marino]

Created attachment 447372 [details]
Patch

[EWS]

Committed r287194 (245361@main): <https://commits.webkit.org/245361@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447372 [details].