Bug 234371

Summary:

[ANGLE] "WARN: driver_utils.cpp:169 (rx::GetVendorString):! Unimplemented: rx::GetVendorString" on WinCairo debug testing bot

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

ANGLE

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, ews-watchlist, geofflang, gman, jonahr, kbr, kkinnunen, kondapallykalyan, kpiddington, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Fujii Hironori 2021-12-15 16:00:50 PST

After r286603 updated ANGLE, WinCairo debug testing bot is observing annoying warning message for all WebGL tessts.

WinCairo-64-bit-WKL-Debug-Tests
https://build.webkit.org/#/builders/32/builds/1384/steps/11/logs/stdio

14:28:24.558 6820 webgl/2.0.0/conformance/uniforms/uniform-values-per-program.html passed
14:28:25.391 6820 worker/0 webgl/2.0.y/conformance2/context/constants-and-properties-2.html output stderr lines:
14:28:25.391 6820   WARN: driver_utils.cpp:169 (rx::GetVendorString): 	! Unimplemented: rx::GetVendorString(..\..\Source\ThirdParty\ANGLE\src\libANGLE\renderer\driver_utils.cpp:169)
14:28:25.391 6820   WARN: driver_utils.cpp:169 (rx::GetVendorString): 	! Unimplemented: rx::GetVendorString(..\..\Source\ThirdParty\ANGLE\src\libANGLE\renderer\driver_utils.cpp:169)
14:28:25.392 6820   TestRunner::notifyDone() called unexpectedly.
14:28:25.392 6820 webgl/2.0.y/conformance2/context/constants-and-properties-2.html passed
14:28:26.488 6820 worker/0 webgl/2.0.y/conformance2/vertex_arrays/vertex-array-object.html output stderr lines:
14:28:26.488 6820   WARN: driver_utils.cpp:169 (rx::GetVendorString): 	! Unimplemented: rx::GetVendorString(..\..\Source\ThirdParty\ANGLE\src\libANGLE\renderer\driver_utils.cpp:169)
14:28:26.488 6820   WARN: driver_utils.cpp:169 (rx::GetVendorString): 	! Unimplemented: rx::GetVendorString(..\..\Source\ThirdParty\ANGLE\src\libANGLE\renderer\driver_utils.cpp:169)
14:28:26.488 6820   TestRunner::notifyDone() called unexpectedly.

Surprisingly, I don't see this warning on my PC.
Is this depending on a GPU driver?

Comment 1 Fujii Hironori 2021-12-15 16:24:22 PST

I'm observing the same problem on the internal testing bot.
dxdiag.exe reports:

           Vendor ID: 0x1414
           Card name: VMware SVGA 3D
        Manufacturer: VMware, Inc.
           Chip type: VMware Virtual SVGA 3D Graphics Adapter

This is the result of my PC:

           Vendor ID: 0x1002
           Card name: AMD Radeon Pro WX 2100
        Manufacturer: Advanced Micro Devices, Inc.
           Chip type: AMD FirePro SDI (0x6995)

Comment 2 Fujii Hironori 2021-12-15 16:35:33 PST

Mozilla has the following code.

https://hg.mozilla.org/mozilla-central/file/tip/widget/GfxDriverInfo.cpp

> DECLARE_VENDOR_ID(Microsoft, "0x1414")

Comment 3 Kenneth Russell 2021-12-15 16:52:01 PST

Please feel free to propose a patch against WebKit's copy of ANGLE

Comment 4 Kenneth Russell 2021-12-15 16:52:36 PST

(oops, didn't mean to submit that comment as is)

...and we'll be happy to help you upstream it to the ANGLE repository.

Comment 5 Fujii Hironori 2021-12-16 18:02:31 PST

Unfortunately, dxdiag.exe doesn't work in the WinCairo-64-bit-WKL-Debug-Tests container.
So, I created a simple program and compiled it in the container. The vendor ID is also 0x1414.
https://gist.github.com/fujii/72df773fe7fa11fd7459755f184cee6a

Comment 6 Fujii Hironori 2021-12-16 21:02:29 PST

Created attachment 447420 [details]
Patch

Comment 7 EWS Watchlist 2021-12-16 21:03:31 PST

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

Comment 8 Kenneth Russell 2021-12-17 12:53:39 PST

Comment on attachment 447420 [details]
Patch

Seems fine. r+

Comment 9 EWS 2021-12-17 13:40:26 PST

Committed r287204 (245371@main): <https://commits.webkit.org/245371@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447420 [details].

Comment 10 Radar WebKit Bug Importer 2021-12-17 13:41:19 PST

<rdar://problem/86648972>