Bug 234370

Summary: Add a "NotificationData" object to encompass local Notification-related parameters, instead of passing tons of them around everywhere
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, darin, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=234437
https://bugs.webkit.org/show_bug.cgi?id=234436
Attachments:
Description Flags
Patch v1
thorton: review+
PFL v1
ews-feeder: commit-queue-
PFL v2
ews-feeder: commit-queue-
PFL v3 none

Brady Eidson
Reported 2021-12-15 15:39:12 PST
Add a "NotificationData" object to encompass local Notification-related parameters, instead of passing tons of them around everywhere
Attachments
Patch v1 (29.13 KB, patch)
2021-12-15 15:49 PST, Brady Eidson
thorton: review+
PFL v1 (28.67 KB, patch)
2021-12-15 16:11 PST, Brady Eidson
ews-feeder: commit-queue-
PFL v2 (29.38 KB, patch)
2021-12-15 16:51 PST, Brady Eidson
ews-feeder: commit-queue-
PFL v3 (29.96 KB, patch)
2021-12-15 17:48 PST, Brady Eidson
no flags
Brady Eidson
Comment 1 2021-12-15 15:49:38 PST
Created attachment 447295 [details] Patch v1
Tim Horton
Comment 2 2021-12-15 15:58:36 PST
Comment on attachment 447295 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=447295&action=review > Source/WebCore/Modules/notifications/NotificationData.h:49 > + encoder << title << body << iconURL << tag << language << direction << originString << notificationID; I feel like traditionally we do one-per-line, though there's nothing wrong with this.
Tim Horton
Comment 3 2021-12-15 15:58:39 PST
Comment on attachment 447295 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=447295&action=review > Source/WebCore/Modules/notifications/NotificationData.h:49 > + encoder << title << body << iconURL << tag << language << direction << originString << notificationID; I feel like traditionally we do one-per-line, though there's nothing wrong with this.
Brady Eidson
Comment 4 2021-12-15 16:11:24 PST
Brady Eidson
Comment 5 2021-12-15 16:51:23 PST
Brady Eidson
Comment 6 2021-12-15 17:48:32 PST
EWS
Comment 7 2021-12-15 19:47:31 PST
Committed r287124 (245308@main): <https://commits.webkit.org/245308@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447304 [details].
Radar WebKit Bug Importer
Comment 8 2021-12-15 19:48:23 PST
Darin Adler
Comment 9 2021-12-16 13:30:07 PST
Comment on attachment 447304 [details] PFL v3 View in context: https://bugs.webkit.org/attachment.cgi?id=447304&action=review > Source/WebCore/Modules/notifications/NotificationData.cpp:31 > +namespace WebCore { > + > +} // namespace WebCore What’s the rationale for creating an empty source file?
Brady Eidson
Comment 10 2021-12-21 16:36:15 PST
(In reply to Darin Adler from comment #9) > Comment on attachment 447304 [details] > PFL v3 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447304&action=review > > > Source/WebCore/Modules/notifications/NotificationData.cpp:31 > > +namespace WebCore { > > + > > +} // namespace WebCore > > What’s the rationale for creating an empty source file? There was definitely a build/link error resolved by it, but I definitely forget what it was.
Brady Eidson
Comment 11 2021-12-21 16:42:12 PST
This patch had a pretty subtle bug which caused a few different types of test flakiness. Look at this file closely and see if you can spot it. https://trac.webkit.org/changeset/287124/webkit/trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp Good news - That type of subtle bug within the "two different notification identifiers" system is why I embarked upon https://bugs.webkit.org/show_bug.cgi?id=234534 which should fix it.
Darin Adler
Comment 12 2021-12-24 09:07:32 PST
(In reply to Brady Eidson from comment #10) > (In reply to Darin Adler from comment #9) > > > Source/WebCore/Modules/notifications/NotificationData.cpp:31 > > > +namespace WebCore { > > > + > > > +} // namespace WebCore > > > > What’s the rationale for creating an empty source file? > > There was definitely a build/link error resolved by it, but I definitely > forget what it was. Let’s follow up on this. Doesn’t make logical sense that we need an empty source file, and I am pretty sure we can remove it.
Note You need to log in before you can comment on or make changes to this bug.