| Summary: | [JSC] Further unification in run-jsc-stress-tests | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Angelos Oikonomopoulos <angelos> | ||||||||
| Component: | New Bugs | Assignee: | Angelos Oikonomopoulos <angelos> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aperez, don.olmstead, jbedard, ryanhaddad, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Angelos Oikonomopoulos
2021-12-15 04:59:07 PST
Created attachment 447225 [details]
Patch
Ping, this is a straightforward refactoring patch (which, by reducing divergence, re-enables some inadvertently omitted testing modes for a few tests). Comment on attachment 447225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447225&action=review > Tools/ChangeLog:12 > + When defaultNoNoLLIntRun was added in https://github.com/WebKit/WebKit/commit/5bdfa5675fffa3939e7a66cb6947b607dc0040ed, Could we use identifiers or revisions here? This one would be https://commits.webkit.org/176404@main (it's in the commit message). The advantage of commits.webkit.org is that those links will redirect to GitHub when SVN dies. Created attachment 449480 [details]
Patch
(In reply to Jonathan Bedard from comment #4) > Comment on attachment 447225 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447225&action=review > > > Tools/ChangeLog:12 > > + When defaultNoNoLLIntRun was added in https://github.com/WebKit/WebKit/commit/5bdfa5675fffa3939e7a66cb6947b607dc0040ed, > > Could we use identifiers or revisions here? This one would be > https://commits.webkit.org/176404@main (it's in the commit message). The > advantage of commits.webkit.org is that those links will redirect to GitHub > when SVN dies. Sure, I've updated the ChangeLog entry to use commits.webkit.org URLs instead. The reason I went with github URLs in the first place was to pick the identifier that looked more likely to remain stable. I guess commits.webkit.org is at least equally likely to remain available :-) Created attachment 449489 [details]
Patch
Committed r288276 (246214@main): <https://commits.webkit.org/246214@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449489 [details]. |