Bug 234343

Summary: [JSC] Further unification in run-jsc-stress-tests
Product: WebKit Reporter: Angelos Oikonomopoulos <angelos>
Component: New BugsAssignee: Angelos Oikonomopoulos <angelos>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, don.olmstead, jbedard, ryanhaddad, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Angelos Oikonomopoulos
Reported 2021-12-15 04:59:07 PST
[JSC] Further unification in run-jsc-stress-tests
Attachments
Patch (8.14 KB, patch)
2021-12-15 05:14 PST, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Patch (8.03 KB, patch)
2022-01-19 06:53 PST, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Patch (8.03 KB, patch)
2022-01-19 09:44 PST, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Angelos Oikonomopoulos
Comment 1 2021-12-15 05:14:56 PST
Created attachment 447225 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-12-22 05:00:17 PST
<rdar://problem/86807341>
Angelos Oikonomopoulos
Comment 3 2022-01-17 03:54:51 PST
Ping, this is a straightforward refactoring patch (which, by reducing divergence, re-enables some inadvertently omitted testing modes for a few tests).
Jonathan Bedard
Comment 4 2022-01-18 10:00:41 PST
Comment on attachment 447225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447225&action=review > Tools/ChangeLog:12 > + When defaultNoNoLLIntRun was added in https://github.com/WebKit/WebKit/commit/5bdfa5675fffa3939e7a66cb6947b607dc0040ed, Could we use identifiers or revisions here? This one would be https://commits.webkit.org/176404@main (it's in the commit message). The advantage of commits.webkit.org is that those links will redirect to GitHub when SVN dies.
Angelos Oikonomopoulos
Comment 5 2022-01-19 06:53:54 PST
Created attachment 449480 [details] Patch
Angelos Oikonomopoulos
Comment 6 2022-01-19 07:03:43 PST
(In reply to Jonathan Bedard from comment #4) > Comment on attachment 447225 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447225&action=review > > > Tools/ChangeLog:12 > > + When defaultNoNoLLIntRun was added in https://github.com/WebKit/WebKit/commit/5bdfa5675fffa3939e7a66cb6947b607dc0040ed, > > Could we use identifiers or revisions here? This one would be > https://commits.webkit.org/176404@main (it's in the commit message). The > advantage of commits.webkit.org is that those links will redirect to GitHub > when SVN dies. Sure, I've updated the ChangeLog entry to use commits.webkit.org URLs instead. The reason I went with github URLs in the first place was to pick the identifier that looked more likely to remain stable. I guess commits.webkit.org is at least equally likely to remain available :-)
Angelos Oikonomopoulos
Comment 7 2022-01-19 09:44:25 PST
Created attachment 449489 [details] Patch
EWS
Comment 8 2022-01-20 02:01:57 PST
Committed r288276 (246214@main): <https://commits.webkit.org/246214@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449489 [details].
Note You need to log in before you can comment on or make changes to this bug.