| Summary: | [:has() pseudo-class] Use Bloom filter to quickly reject :has() selectors | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||||||
| Component: | CSS | Assignee: | Antti Koivisto <koivisto> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | allan.jensen, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||
| Bug Blocks: | 227702 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Antti Koivisto
2021-12-15 02:55:33 PST
Created attachment 447218 [details]
Patch
Created attachment 447224 [details]
Patch
Comment on attachment 447224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447224&action=review > Source/WebCore/ChangeLog:48 > + Add HasSelectorFilter which uses non-counting BloomFilter internally. The size of the filter is 64 bytes. I don't understand how BloomFilter<14> is 64 bytes but I'll take your word for it. > I don't understand how BloomFilter<14> is 64 bytes but I'll take your word
> for it.
It is not!
Created attachment 447244 [details]
Patch for landing
Created attachment 447247 [details]
Patch for landing
Tools/Scripts/svn-apply failed to apply attachment 447247 [details] to trunk.
Please resolve the conflicts and upload a new patch.
It is now BloomFilter<12> and 512 bytes (hopefully) Created attachment 447249 [details]
Patch for landing
Comment on attachment 447249 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=447249&action=review > Source/WebCore/ChangeLog:18 > + Use it to quikly reject selectors. quikly -> quickly Created attachment 447258 [details]
Patch
Created attachment 447259 [details]
Patch for landing
Committed r287091 (245283@main): <https://commits.webkit.org/245283@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447259 [details]. |