Bug 234329

Summary:

Actually use adattributiond.entitlements when code signing adattributiond

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Alex Christensen 2021-12-14 18:11:32 PST

Actually use adattributiond.entitlements when code signing adattributiond

Comment 1 Alex Christensen 2021-12-14 18:15:51 PST

Created attachment 447187 [details]
Patch

Comment 2 Alex Christensen 2021-12-14 18:17:02 PST

Created attachment 447188 [details]
Patch

Comment 3 Tim Horton 2021-12-14 18:19:50 PST

Comment on attachment 447188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447188&action=review

> Source/WebKit/Configurations/adattributiond.xcconfig:34
> +WK_CODE_SIGN_FLAGS_iphoneos = --entitlements $(WK_PROCESSED_XCENT_FILE);

Do you not want CODE_SIGN_ENTITLEMENTS instead?

Comment 4 Alex Christensen 2021-12-14 21:50:13 PST

Using CODE_SIGN_ENTITLEMENTS causes a build failure, something about a dependency problem.  I think that is to be used when the entitlements file is in the repo, but here the entitlements file is generated in the temporary directory.

Comment 5 EWS 2021-12-15 13:08:04 PST

Committed r287100 (245289@main): <https://commits.webkit.org/245289@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447188 [details].

Comment 6 Radar WebKit Bug Importer 2021-12-15 13:09:15 PST

<rdar://problem/86539150>