Bug 234265

Summary: Teach webpushtool to register and "host" the daemon
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, pangle, saam, thorton, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1
ews-feeder: commit-queue-
Patch v2
thorton: review+
PFL v1 none

Description Brady Eidson 2021-12-13 13:50:08 PST 
Teach webpushtool to register and "host" the daemon
Comment 1 Brady Eidson 2021-12-13 13:55:40 PST 
Created attachment 447059 [details]
Patch v1
Comment 2 Brady Eidson 2021-12-13 15:08:13 PST 
Created attachment 447074 [details]
Patch v2
Comment 3 Tim Horton 2021-12-13 16:47:27 PST 
Comment on attachment 447074 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=447074&action=review

> Source/WebKit/webpushd/WebPushDaemon.mm:190
> +    broadcastDebugMessage((JSC::MessageLevel)4, "===\nCurrent connections:");

Does this really not have a name?

> Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h:55
> +    Yes,
> +    No,

Oh dear, please flip all of these enums to save people who use debuggers.
Comment 4 Brady Eidson 2021-12-13 19:06:12 PST 
Created attachment 447094 [details]
PFL v1
Comment 5 EWS 2021-12-13 20:24:39 PST 
Committed r287009 (245214@main): <https://commits.webkit.org/245214@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447094 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-13 20:25:18 PST 
<rdar://problem/86448305>
Comment 7 Brady Eidson 2021-12-13 21:00:03 PST 
Did all the ConsoleTypes.h refactoring and *forgot to git add the change to use the JSC::MessageType enum in WebPushD*

Will do in followup.