Bug 234264

Summary:

Adhere to DisplayList iterator's API contract in MemoryDisplayList::~InMemoryDisplayList()

Product:

WebKit

Reporter:

Gabriel Nava Marino <gnavamarino>

Component:

New Bugs

Assignee:

Gabriel Nava Marino <gnavamarino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mmaxfield, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Gabriel Nava Marino 2021-12-13 13:34:37 PST

We need to breakout out of iteration if the item is nullopt.

Comment 1 Gabriel Nava Marino 2021-12-13 13:35:17 PST

<rdar://problem/86152753>

Comment 2 Gabriel Nava Marino 2021-12-13 13:39:37 PST

Created attachment 447054 [details]
Patch

Comment 3 Myles C. Maxfield 2021-12-14 14:08:11 PST

Comment on attachment 447054 [details]
Patch

We should consider modifying DisplayList::Iterator::operator== to see if this behavior can automatically occur for all display list iteration. This is fine for now, though.

Comment 4 EWS 2021-12-14 14:17:05 PST

Committed r287048 (245245@main): <https://commits.webkit.org/245245@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447054 [details].