Bug 234250

Summary: [MacCatalyst] fix iOSMac after refactor in r286899
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: New BugsAssignee: Kyle Piddington <kpiddington>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, kbr, kondapallykalyan, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Kyle Piddington 2021-12-13 10:11:08 PST
[MacCatalyst] fix iOSMac after refactor in r286899
Comment 1 Kyle Piddington 2021-12-13 10:14:44 PST
Created attachment 447022 [details]
Patch
Comment 2 EWS Watchlist 2021-12-13 10:15:54 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Dean Jackson 2021-12-13 10:18:08 PST
Comment on attachment 447022 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447022&action=review

> Source/ThirdParty/ANGLE/ChangeLog:11
> +	Also includes a longer term fix for 
> +	https://bugs.webkit.org/show_bug.cgi?id=233977
> +
> +	Tested builds on mac, iOS, TV SDKs, plus iOSMac

I think you have some tabs here!
Comment 4 Myles C. Maxfield 2021-12-13 10:37:02 PST
Comment on attachment 447022 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447022&action=review

> Source/ThirdParty/ANGLE/src/common/platform.h:-135
> -#            undef TARGET_OS_IOS

🎉🎉🎉
Comment 5 Kyle Piddington 2021-12-13 10:42:59 PST
Created attachment 447026 [details]
Patch for landing
Comment 6 EWS 2021-12-13 12:01:05 PST
Committed r286964 (245187@main): <https://commits.webkit.org/245187@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447026 [details].
Comment 7 Radar WebKit Bug Importer 2021-12-13 12:02:32 PST
<rdar://problem/86425732>