Bug 234246

Summary: Web Inspector: Computed Panel: Adjust color of CSS Variables grouping mode control
Product: WebKit Reporter: Razvan Caliman <rcaliman>
Component: Web InspectorAssignee: Razvan Caliman <rcaliman>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 233563    
Bug Blocks:    
Attachments:
Description Flags
Screenshot before patch
none
Screenshot with patch applied
none
[fast-cq] Patch 1.0
none
[fast-cq] Patch 1.1 none

Razvan Caliman
Reported 2021-12-13 08:59:58 PST
Selected items show up in bright blue which draws disproportionate attention.
Attachments
Screenshot before patch (96.73 KB, image/png)
2021-12-13 09:01 PST, Razvan Caliman 		no flags
Details
Screenshot with patch applied (93.78 KB, image/png)
2021-12-13 09:01 PST, Razvan Caliman 		no flags
Details
[fast-cq] Patch 1.0 (3.05 KB, patch)
2021-12-13 09:04 PST, Razvan Caliman 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch 1.1 (2.83 KB, patch)
2021-12-14 07:35 PST, Razvan Caliman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Razvan Caliman
Comment 1 2021-12-13 09:01:14 PST
Created attachment 447011 [details] Screenshot before patch
Radar WebKit Bug Importer
Comment 2 2021-12-13 09:01:29 PST
<rdar://problem/86414682>
Razvan Caliman
Comment 3 2021-12-13 09:01:34 PST
Created attachment 447012 [details] Screenshot with patch applied
Razvan Caliman
Comment 4 2021-12-13 09:04:46 PST
Created attachment 447013 [details] [fast-cq] Patch 1.0 Minor design tweak. Follow-up to Bug 233563
Devin Rousso
Comment 5 2021-12-13 10:22:26 PST
Comment on attachment 447013 [details] [fast-cq] Patch 1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=447013&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.css:76 > + --scope-bar-background-color-override: unset; Is this actually needed? This rule should never overlap with the one above, so it shouldn't be necessary to `unset` this.
Razvan Caliman
Comment 6 2021-12-14 07:35:01 PST
Created attachment 447131 [details] [fast-cq] Patch 1.1
Razvan Caliman
Comment 7 2021-12-14 07:35:32 PST
Comment on attachment 447013 [details] [fast-cq] Patch 1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=447013&action=review >> Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.css:76 >> + --scope-bar-background-color-override: unset; > > Is this actually needed? This rule should never overlap with the one above, so it shouldn't be necessary to `unset` this. You're right. This is not necessary.
EWS
Comment 8 2021-12-14 07:50:52 PST
Committed r287022 (?): <https://commits.webkit.org/r287022> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447131 [details].
Note You need to log in before you can comment on or make changes to this bug.