Bug 234235 – [LBSE] Rename RenderSVGModelObject -> LegacyRenderSVGModelObject

• Component: SVG
• Status: RESOLVED FIXED

[Nikolas Zimmermann]

The LBSE RenderSVGModelObject will inherit from RenderLayerModelObject. Therefore we have to re-introduce a fresh RenderSVGModelObject for LBSE and rename the current one.

[Nikolas Zimmermann]

Created attachment 446990 [details]
Patch, v1

[Rob Buis]

Comment on attachment 446990 [details]
Patch, v1

View in context: https://bugs.webkit.org/attachment.cgi?id=446990&action=review

> Source/WebCore/rendering/RenderObject.h:351
> +    bool isRenderSVGModelObjectOrLegacyRenderSVGModelObject() const { return isRenderSVGModelObject() || isLegacyRenderSVGModelObject(); }

Not too fond of the length. isARenderSVGModelObject? isRenderSVGModelObjectLike?

[Nikolas Zimmermann]

(In reply to Rob Buis from comment #2)
> Comment on attachment 446990 [details]
> Patch, v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=446990&action=review
> 
> > Source/WebCore/rendering/RenderObject.h:351
> > +    bool isRenderSVGModelObjectOrLegacyRenderSVGModelObject() const { return isRenderSVGModelObject() || isLegacyRenderSVGModelObject(); }
> 
> Not too fond of the length. isARenderSVGModelObject?
> isRenderSVGModelObjectLike?

I named it following the convention for RenderSVGRoot, which established  isRenderSVGRootOrLegacySVGRoot. I think if we change this, we should change both, no?

isRenderOrLegacyRenderSVGModelObject / isRenderOrLegacyRenderSVGRoot
Is that better?

[Rob Buis]

Comment on attachment 446990 [details]
Patch, v1

View in context: https://bugs.webkit.org/attachment.cgi?id=446990&action=review

>>> Source/WebCore/rendering/RenderObject.h:351
>>> +    bool isRenderSVGModelObjectOrLegacyRenderSVGModelObject() const { return isRenderSVGModelObject() || isLegacyRenderSVGModelObject(); }
>> 
>> Not too fond of the length. isARenderSVGModelObject? isRenderSVGModelObjectLike?
> 
> I named it following the convention for RenderSVGRoot, which established  isRenderSVGRootOrLegacySVGRoot. I think if we change this, we should change both, no?
> 
> isRenderOrLegacyRenderSVGModelObject / isRenderOrLegacyRenderSVGRoot
> Is that better?

Yes, I like that better!

[Nikolas Zimmermann]

(In reply to Rob Buis from comment #4)
> Comment on attachment 446990 [details]
> Patch, v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=446990&action=review
> 
> >>> Source/WebCore/rendering/RenderObject.h:351
> >>> +    bool isRenderSVGModelObjectOrLegacyRenderSVGModelObject() const { return isRenderSVGModelObject() || isLegacyRenderSVGModelObject(); }
> >> 
> >> Not too fond of the length. isARenderSVGModelObject? isRenderSVGModelObjectLike?
> > 
> > I named it following the convention for RenderSVGRoot, which established  isRenderSVGRootOrLegacySVGRoot. I think if we change this, we should change both, no?
> > 
> > isRenderOrLegacyRenderSVGModelObject / isRenderOrLegacyRenderSVGRoot
> > Is that better?
> 
> Yes, I like that better!

Good will land that with the new name. One thing was incorrect: the naming scheme for RenderSVGRoot is different, the identifier is not named isRenderSVGRoot() but isSVGRoot(), thus a different naming scheme is fine for RenderSVGRoot - it can stay as-is.

[Nikolas Zimmermann]

Committed r286962 (245185@trunk): <https://commits.webkit.org/245185@trunk>

[Radar WebKit Bug Importer]

<rdar://problem/86425263>

[Nikolas Zimmermann]

Reopening to attach new patch.

[Nikolas Zimmermann]

Created attachment 447744 [details]
Patch, v2

[Nikolas Zimmermann]

Sorry for the noise, typo in the bug number... no new patch is needed here.