Bug 234215
| Summary: | SharedBufferBuilder copy constructor should be deleted | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=224092 https://bugs.webkit.org/show_bug.cgi?id=233511 |
||
| Bug Depends on: | 233442 | ||
| Bug Blocks: | |||
Jean-Yves Avenard [:jya]
Bug 233442 introduced SharedBufferBuilder ; the aim was to guarantee immutability of a SharedBuffer once created.
As such, copying a SharedBufferBuilder doesn't make much sense or it should make a copy of the underlying SharedBuffer before copying.
This paradigm isn't enforceable due to how ScriptBufferSourceProvider is using a ScriptBuffer which itself contains a SharedBufferBuilder
A ScriptBuffer is a wrapper around a SharedBuffer, designed to makes it clearer what type of data it's dealing with.
We should remove the need for copying a SharedBufferBuilder, or have ScriptBufferSourceProvider::m_scriptBuffer itself made immutable (which is prevented by ServiceWorkerGlobalScope::didSaveScriptsToDisk)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/86699446>