Bug 234189

Summary:

Momentum Event Dispatcher: Magic Mouse doesn't use momentum event dispatcher

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Tim Horton 2021-12-10 17:23:22 PST

Momentum Event Dispatcher: Magic Mouse doesn't use momentum event dispatcher

Comment 1 Tim Horton 2021-12-10 17:24:40 PST

Created attachment 446850 [details]
Patch

Comment 2 Tim Horton 2021-12-10 17:24:43 PST

<rdar://problem/86344954>

Comment 3 Simon Fraser (smfr) 2021-12-10 17:27:57 PST

Comment on attachment 446850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446850&action=review

> Source/WebKit/Shared/mac/ScrollingAccelerationCurveMac.mm:123
> +        return fromFixedPoint([(NSNumber *)valueCF.get() floatValue]);

Do we need to guard against it not being a CFNumber?

Comment 4 Tim Horton 2021-12-10 17:29:59 PST

Comment on attachment 446850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446850&action=review

>> Source/WebKit/Shared/mac/ScrollingAccelerationCurveMac.mm:123
>> +        return fromFixedPoint([(NSNumber *)valueCF.get() floatValue]);
> 
> Do we need to guard against it not being a CFNumber?

see the dynamic_cf_cast above

Comment 5 EWS 2021-12-10 19:45:00 PST

Committed r286900 (245128@main): <https://commits.webkit.org/245128@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446850 [details].