Summary: | Automatically forbid JS execution when we throw a TerminationException. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, youennf, ysuzuki | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mark Lam
2021-12-10 17:10:26 PST
Created attachment 446848 [details]
proposed patch.
Comment on attachment 446848 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=446848&action=review r=me > Source/JavaScriptCore/runtime/VM.h:1123 > + bool m_forbidExecutionOnTermination { false }; Since forbidExecutionOnTermination is verb and there is m_executionForbidden, I think renaming it to m_executionOnTerminationForbidden is better. (In reply to Yusuke Suzuki from comment #2) > Comment on attachment 446848 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=446848&action=review > > r=me Thanks. > > Source/JavaScriptCore/runtime/VM.h:1123 > > + bool m_forbidExecutionOnTermination { false }; > > Since forbidExecutionOnTermination is verb and there is > m_executionForbidden, I think renaming it to > m_executionOnTerminationForbidden is better. How about m_executionForbiddenOnTermination instead? (In reply to Mark Lam from comment #3) > > > Source/JavaScriptCore/runtime/VM.h:1123 > > > + bool m_forbidExecutionOnTermination { false }; > > > > Since forbidExecutionOnTermination is verb and there is > > m_executionForbidden, I think renaming it to > > m_executionOnTerminationForbidden is better. > > How about m_executionForbiddenOnTermination instead? I think I'll just go with this i.e. m_executionForbiddenOnTermination. Created attachment 446851 [details]
[fast-cq] patch for landing.
The jsc-armv7-tests EWS bot was showing red, but this simple patch should have 0 behavior change on JSC tests. So, the failures has to be due to something else. Also, the jsc-armv7-tests EWS bot appears to be showing severe infrastructure failures. Hence, I'm just going to move forward and land this. Committed r286913 (245139@main): <https://commits.webkit.org/245139@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446851 [details]. |