Bug 234173

Summary: Update Install Paths for build system changes
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: PlatformAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, david_quesada, dino, eric.carlson, ews-watchlist, hi, kbr, keith_miller, kondapallykalyan, mark.lam, pangle, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Update patch - Removed update of DYLIB_INSTALL_NAME_BASE
ysuzuki: review+
Update - Found that the WebKit services needed install locations updates. none

Michael Saboff
Reported 2021-12-10 13:28:48 PST
Add a configurable system path to work with updates to the build system.
Attachments
Patch (17.97 KB, patch)
2021-12-10 14:48 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Update patch - Removed update of DYLIB_INSTALL_NAME_BASE (15.65 KB, patch)
2021-12-10 16:15 PST, Michael Saboff 		ysuzuki: review+
DetailsFormatted DiffDiff
Update - Found that the WebKit services needed install locations updates. (16.79 KB, patch)
2021-12-10 17:23 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2021-12-10 13:29:29 PST
<rdar://84983741>
Michael Saboff
Comment 2 2021-12-10 14:48:05 PST
Created attachment 446819 [details] Patch
EWS Watchlist
Comment 3 2021-12-10 14:48:58 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Michael Saboff
Comment 4 2021-12-10 16:15:04 PST
Created attachment 446839 [details] Update patch - Removed update of DYLIB_INSTALL_NAME_BASE
David Quesada
Comment 5 2021-12-10 16:36:03 PST
Comment on attachment 446839 [details] Update patch - Removed update of DYLIB_INSTALL_NAME_BASE View in context: https://bugs.webkit.org/attachment.cgi?id=446839&action=review > Source/WebKit/Configurations/WebKit.xcconfig:36 > +INSTALL_PATH = $(INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_$(USE_SYSTEM_CONTENT_PATH)); Does this also apply to the items within the framework? (e.g. the XPC services) If you're configuring the framework bundle this way, any targets installed within it should probably update *their* install paths the same way.
Yusuke Suzuki
Comment 6 2021-12-10 16:51:37 PST
Comment on attachment 446839 [details] Update patch - Removed update of DYLIB_INSTALL_NAME_BASE rs=me
Michael Saboff
Comment 7 2021-12-10 16:54:03 PST
Comment on attachment 446839 [details] Update patch - Removed update of DYLIB_INSTALL_NAME_BASE View in context: https://bugs.webkit.org/attachment.cgi?id=446839&action=review >> Source/WebKit/Configurations/WebKit.xcconfig:36 >> +INSTALL_PATH = $(INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_$(USE_SYSTEM_CONTENT_PATH)); > > Does this also apply to the items within the framework? (e.g. the XPC services) If you're configuring the framework bundle this way, any targets installed within it should probably update *their* install paths the same way. This appears to be used for all items in the framework, so I think we are good.
Michael Saboff
Comment 8 2021-12-10 17:23:26 PST
Created attachment 446849 [details] Update - Found that the WebKit services needed install locations updates.
EWS
Comment 9 2021-12-10 18:33:16 PST
Committed r286896 (245124@main): <https://commits.webkit.org/245124@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446849 [details].
Note You need to log in before you can comment on or make changes to this bug.