| Summary: | ASTC-HDR is unavailable on some platforms | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kyle Piddington <kpiddington> | ||||||||||||
| Component: | ANGLE | Assignee: | Kyle Piddington <kpiddington> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | dino, ews-watchlist, gman, jonahr, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Kyle Piddington
2021-12-10 11:52:13 PST
Created attachment 446775 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 446775 [details]
Patch
How urgently does this fix need to make it into WebKit?
It would be better in the long run if this patch were reviewed upstream in ANGLE and then the update-angle script were run in WebKit to pull it in.
Comment on attachment 446775 [details]
Patch
Kyle and I chatted on Slack and it's clear this is urgent, so r+ and let's upstream it later.
Created attachment 446818 [details]
Patch
Created attachment 446841 [details]
Patch
Created attachment 446846 [details]
Patch
Comment on attachment 446846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446846&action=review > Source/ThirdParty/ANGLE/ChangeLog:6 > + Update autogenerated format table to avoid using ASTC_HDR on The ChangeLog formatting is strange - suggest you revisit this and match the other entries. Created attachment 446852 [details]
Patch for landing
Committed r286899 (245127@main): <https://commits.webkit.org/245127@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446852 [details]. |