Bug 234164

Summary: ASTC-HDR is unavailable on some platforms
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: ANGLEAssignee: Kyle Piddington <kpiddington>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, gman, jonahr, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Kyle Piddington
Reported 2021-12-10 11:52:13 PST
ASTC-HDR is unavailable on TVOS
Attachments
Patch (38.27 KB, patch)
2021-12-10 11:53 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (39.96 KB, patch)
2021-12-10 14:38 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (41.44 KB, patch)
2021-12-10 16:23 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (41.53 KB, patch)
2021-12-10 16:39 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch for landing (41.55 KB, patch)
2021-12-10 18:03 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Kyle Piddington
Comment 1 2021-12-10 11:53:03 PST
Created attachment 446775 [details] Patch
EWS Watchlist
Comment 2 2021-12-10 11:53:47 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 3 2021-12-10 12:01:46 PST
Comment on attachment 446775 [details] Patch How urgently does this fix need to make it into WebKit? It would be better in the long run if this patch were reviewed upstream in ANGLE and then the update-angle script were run in WebKit to pull it in.
Kenneth Russell
Comment 4 2021-12-10 12:25:07 PST
Comment on attachment 446775 [details] Patch Kyle and I chatted on Slack and it's clear this is urgent, so r+ and let's upstream it later.
Kyle Piddington
Comment 5 2021-12-10 14:38:55 PST
Created attachment 446818 [details] Patch
Kyle Piddington
Comment 6 2021-12-10 16:23:18 PST
Created attachment 446841 [details] Patch
Kyle Piddington
Comment 7 2021-12-10 16:39:08 PST
Created attachment 446846 [details] Patch
Kenneth Russell
Comment 8 2021-12-10 17:47:26 PST
Comment on attachment 446846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446846&action=review > Source/ThirdParty/ANGLE/ChangeLog:6 > + Update autogenerated format table to avoid using ASTC_HDR on The ChangeLog formatting is strange - suggest you revisit this and match the other entries.
Kyle Piddington
Comment 9 2021-12-10 18:03:51 PST
Created attachment 446852 [details] Patch for landing
EWS
Comment 10 2021-12-10 19:26:02 PST
Committed r286899 (245127@main): <https://commits.webkit.org/245127@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446852 [details].
Radar WebKit Bug Importer
Comment 11 2021-12-10 19:27:19 PST
<rdar://problem/86350864>
Note You need to log in before you can comment on or make changes to this bug.