Bug 234139

Summary:	[WPT] test_driver.Actions() not working properly
Product:	WebKit	Reporter:	Manuel Rego Casasnovas <rego>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	graouts, gsnedders, webkit-bug-importer
Priority:	P2	Keywords:	InRadar, WPTImpact
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Manuel Rego Casasnovas 2021-12-10 03:45:29 PST

In several WPT tests that are using test_driver.Actions() we get the following error:
	ReferenceError: Can't find variable: action

This is a list of tests with such error:
	imported/w3c/web-platform-tests/css/css-scroll-snap/snap-at-user-scroll-end-expected.txt
	imported/w3c/web-platform-tests/dom/events/document-level-wheel-event-listener-passive-by-default-expected.txt
	imported/w3c/web-platform-tests/dom/events/document-level-wheel-event-listener-passive-by-default.tentative-expected.txt
	imported/w3c/web-platform-tests/dom/events/scrolling/iframe-chains-expected.txt
	imported/w3c/web-platform-tests/html/semantics/forms/the-button-element/active-onblur-expected.txt
	imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/checkable-active-onblur-expected.txt
	imported/w3c/web-platform-tests/html/semantics/forms/the-label-element/proxy-modifier-click-to-associated-element.tentative-expected.txt
	imported/w3c/web-platform-tests/pointerevents/compat/pointerevent_mouseevent_key_pressed-expected.txt
	imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-keyboard-expected.txt
	imported/w3c/web-platform-tests/shadow-dom/accesskey.tentative-expected.txt
	imported/w3c/web-platform-tests/uievents/order-of-events/focus-events/focus-management-expectations-expected.txt
	imported/w3c/web-platform-tests/uievents/order-of-events/mouse-events/wheel-basic-expected.txt
	imported/w3c/web-platform-tests/uievents/order-of-events/mouse-events/wheel-scrolling-expected.txt

Comment 1 Manuel Rego Casasnovas 2021-12-10 03:56:40 PST

It's worth noting that these tests run fine in wpt.fyi:
https://wpt.fyi/results/shadow-dom/accesskey.tentative.html

Comment 2 Radar WebKit Bug Importer 2021-12-17 03:46:17 PST

<rdar://problem/86625135>

Comment 3 Sam Sneddon [:gsnedders] 2022-01-19 12:13:03 PST

@http://localhost:8800/resources/testdriver-vendor.js:264:75
send@http://localhost:8800/resources/testdriver-actions.js:70:41
global code@http://localhost:8800/css/css-scroll-snap/snap-at-user-scroll-end.html:107:12

So it's the reference to action at https://github.com/WebKit/WebKit/blob/eb14e0ccb41166c7509ce8b445d4e663a1dfd31a/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js#L264

Blame claims it's a regression from https://github.com/WebKit/WebKit/commit/95ae6591e8f12d43817a52ad728e9c438bf9a0cc, bug 197101.