Bug 234110

Summary:

[LFC][IFC] Replace Vector<std::unique_ptr<DisplayBoxNode> with Vector<DisplayBoxTree::Node>

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2021-12-09 15:59:35 PST

as suggested in bug 233880

Comment 1 zalan 2021-12-09 16:11:41 PST

Created attachment 446627 [details]
Patch

Comment 2 Antti Koivisto 2021-12-10 06:05:57 PST

Comment on attachment 446627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446627&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:347
> +        // Node index in m_displayBoxNodes.
> +        size_t thisIndex { 0 };

This doesn't appear to be used.

Comment 3 zalan 2021-12-10 07:46:01 PST

Created attachment 446727 [details]
Patch

Comment 4 EWS 2021-12-10 08:21:53 PST

Committed r286851 (245084@main): <https://commits.webkit.org/245084@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446727 [details].

Comment 5 Radar WebKit Bug Importer 2021-12-10 08:22:20 PST

<rdar://problem/86322728>