Bug 234090

Summary:

[ iOS EWS ] 2X media/track (layout-tests) are a constant image failure

Product:

WebKit

Reporter:

Robert Jenner <jenner>

Component:

Media

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=233901

Attachments:

Description	Flags
Image diffs for failing tests.	none
Patch	none
Patch	none

Robert Jenner

Reported 2021-12-09 10:36:08 PST

The following two media/track tests are constant image failures on iOS, and have been marked as a pre-existing failure on EWS. media/track/track-webvtt-no-snap-to-lines-overlap.html media/track/track-webvtt-snap-to-lines-left-right.html HISTORY: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=media%2Ftrack%2Ftrack-webvtt-no-snap-to-lines-overlap.html&test=media%2Ftrack%2Ftrack-webvtt-snap-to-lines-left-right.html EWS: https://ews-build.webkit.org/#/builders/68 DIFF URLS: https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-WK2-Tests/r286778%20(680)/media/track/track-webvtt-no-snap-to-lines-overlap-diff.png https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-WK2-Tests/r286778%20(680)/media/track/track-webvtt-snap-to-lines-left-right-diff.png Image diffs also attached to this bug.

Attachments
Image diffs for failing tests. (3.74 KB, application/zip) 2021-12-09 10:37 PST, Robert Jenner	no flags	Details
Patch (2.39 KB, patch) 2021-12-13 12:26 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch (3.24 KB, patch) 2021-12-14 20:48 PST, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Robert Jenner

Comment 1 2021-12-09 10:37:56 PST

Created attachment 446565 [details] Image diffs for failing tests.

Robert Jenner

Comment 2 2021-12-09 10:46:12 PST

Since this was having a negative impact on EWS. I have marked the tests as ImageOnlyFailure here: https://trac.webkit.org/changeset/286787/webkit

Robert Jenner

Comment 3 2021-12-09 11:14:39 PST

<rdar://problem/86281284>

Jer Noble

Comment 4 2021-12-13 12:26:17 PST

Created attachment 447044 [details] Patch

Jer Noble

Comment 5 2021-12-14 20:48:57 PST

Created attachment 447199 [details] Patch

EWS

Comment 6 2021-12-15 08:26:38 PST

Committed r287074 (245269@main): <https://commits.webkit.org/245269@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447199 [details].

Note You need to log in before you can comment on or make changes to this bug.