Summary: | Implement MediaPlayerPrivate::hasVideo() on Windows | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Eric Carlson
2009-01-17 16:24:39 PST
Created attachment 26958 [details]
proposed patch
Comment on attachment 26958 [details]
proposed patch
WebKit style would not check != NULL (or use NULL at all)...
+ return (GetMovieIndTrackType(m_private->m_movie, 1, VisualMediaCharacteristic, movieTrackCharacteristic | movieTrackEnabledOnly) != NULL);
Should be:
+ return GetMovieIndTrackType(m_private->m_movie, 1, VisualMediaCharacteristic, movieTrackCharacteristic | movieTrackEnabledOnly);
Why is your test case being added to the platform/mac directory if this is a windows test?
The fix is Windows only, but the test is for the feature (controller always visible on a <video> element with no visual media), which had no test case before now. The test and results are in platform/mac/media/ because it has an expected image and the cygwin version of run-webkit-tests looks there (don't know why that is). Removed the NULL check. Committed as revision 40193. |