Bug 23407

Summary: Implement MediaPlayerPrivate::hasVideo() on Windows
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
proposed patch adele: review+

Eric Carlson
Reported 2009-01-17 16:24:39 PST
The Windows implementation of MediaPlayerPrivate::hasVideo() is hard coded to return true. The method is used by RenderMedia to make sure the controls for a <video> element without any video media are always visible (just like an <audio> element).
Attachments
proposed patch (47.73 KB, patch)
2009-01-22 21:57 PST, Eric Carlson 		adele: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2009-01-22 21:57:57 PST
Created attachment 26958 [details] proposed patch
Eric Seidel (no email)
Comment 2 2009-01-23 00:49:43 PST
Comment on attachment 26958 [details] proposed patch WebKit style would not check != NULL (or use NULL at all)... + return (GetMovieIndTrackType(m_private->m_movie, 1, VisualMediaCharacteristic, movieTrackCharacteristic | movieTrackEnabledOnly) != NULL); Should be: + return GetMovieIndTrackType(m_private->m_movie, 1, VisualMediaCharacteristic, movieTrackCharacteristic | movieTrackEnabledOnly); Why is your test case being added to the platform/mac directory if this is a windows test?
Eric Carlson
Comment 3 2009-01-23 15:41:52 PST
The fix is Windows only, but the test is for the feature (controller always visible on a <video> element with no visual media), which had no test case before now. The test and results are in platform/mac/media/ because it has an expected image and the cygwin version of run-webkit-tests looks there (don't know why that is).
Eric Carlson
Comment 4 2009-01-23 15:42:33 PST
Removed the NULL check. Committed as revision 40193.
Note You need to log in before you can comment on or make changes to this bug.