| Summary: | Use thread safe initialization for statics in Font::getCFStringAttributes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Cameron McCormack (:heycam) <heycam> | ||||||
| Component: | Layout and Rendering | Assignee: | Cameron McCormack (:heycam) <heycam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, darin, mattwoodrow, mmaxfield, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=234102 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 233488 | ||||||||
| Attachments: |
|
||||||||
|
Description
Cameron McCormack (:heycam)
2021-12-08 18:34:19 PST
Created attachment 446476 [details]
Patch
This is another one where the benefit of avoiding allocating these objects might be overwhelmed by the lines of code to do the caching. Comment on attachment 446476 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446476&action=review > Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:46 > +static CFNumberRef zeroKerningValue() This function just returns a float zero. I don’t think its name should include "kerning value". It can be reused by anyone who needs a 0.0f as a CFNumber. This too won't be needed if bug 234102 works. Created attachment 461058 [details]
Patch
Committed 252677@main (070a876c5310): <https://commits.webkit.org/252677@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461058 [details]. |