Bug 234037

Summary: Refactoring: Make MediaPlayerEnums and HTMLMediaElementEnums namespaces rather than classes
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: NEW ---    
Severity: Normal CC: calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, pdr, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[fast-cq] Follow-up patch
none
Patch eric.carlson: review+, ews-feeder: commit-queue-

Description Jer Noble 2021-12-08 14:47:29 PST 
Refactoring: Make MediaPlayerEnums and HTMLMediaElementEnums namespaces rather than classes
Comment 1 Jer Noble 2021-12-08 14:55:01 PST Comment hidden (obsolete)
Comment 2 Jer Noble 2021-12-08 15:01:35 PST 
Created attachment 446434 [details]
Patch
Comment 3 Eric Carlson 2021-12-08 15:33:10 PST 
Comment on attachment 446434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446434&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:1323
> -        m_networkState = NETWORK_LOADING;
> +        m_networkState = NetworkState::Idle;

This seems wrong.

> Source/WebCore/html/HTMLMediaElement.cpp:1460
> -    m_networkState = NETWORK_LOADING;
> +    m_networkState = NetworkState::Idle;

Ditto

> Source/WebCore/html/HTMLMediaElement.cpp:2320
> -        if (m_networkState < NETWORK_LOADING || m_networkState == NETWORK_NO_SOURCE)
> +        if (m_networkState < NetworkState::Idle || m_networkState == NetworkState::NoSource)

Ditto.

> Source/WebCore/html/HTMLMediaElement.cpp:2322
> -        m_networkState = NETWORK_LOADING;
> +        m_networkState = NetworkState::Idle;

Ditto.

> Source/WebCore/html/HTMLMediaElement.cpp:2918
> -    if (m_networkState != NETWORK_LOADING)
> +    if (m_networkState != NetworkState::Idle)

Ditto

> Source/WebCore/html/HTMLMediaElement.cpp:3928
> -    return !paused() && m_networkState == NETWORK_LOADING && m_readyState <= HAVE_CURRENT_DATA;
> +    return !paused() && m_networkState == NetworkState::Idle && m_readyState <= ReadyState::HaveCurrentData;

Ditto

> Source/WebCore/html/HTMLMediaElement.cpp:3943
> -    return !paused() && m_networkState == NETWORK_LOADING && m_readyState <= HAVE_CURRENT_DATA && m_sentStalledEvent;
> +    return !paused() && m_networkState == NetworkState::Idle && m_readyState <= ReadyState::HaveCurrentData && m_sentStalledEvent;

Ditto

> Source/WebCore/html/HTMLMediaElement.cpp:4932
> -    m_networkState = NETWORK_LOADING;
> +    m_networkState = NetworkState::Idle;

Ditto.

> Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.h:84
> +        MediaPlayerEnums::VideoFullscreenMode mode() const { return m_mode; }

Nit: extra indentation
Comment 4 Radar WebKit Bug Importer 2021-12-15 14:48:17 PST 
<rdar://problem/86543781>