Bug 234026

Summary: [MSE] Add a Modules/mediasource/README.md file
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, eric.carlson, ews-watchlist, glenn, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing
none
[fast-cq] Follow-up patch
ews-feeder: commit-queue-
[fast-cq] Follow-up patch none

Description Jer Noble 2021-12-08 12:04:33 PST 
[MSE] Add a Modules/mediasource/README.md file
Comment 1 Jer Noble 2021-12-08 12:05:38 PST 
Created attachment 446404 [details]
Patch
Comment 2 Eric Carlson 2021-12-08 12:30:36 PST 
Comment on attachment 446404 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446404&action=review

> Source/WebCore/Modules/mediasource/README.md:7
> +The Media Source Extensions specification defines a set of classes which allows clients to implement their own loading, buffering, and variant switching behavior, as opposed to allowing the UA to handle same.

Maybe "as opposed to requiring the UA to" instead of "allowing"?

> Source/WebCore/Modules/mediasource/README.md:59
> +MediaSample is an abstract base class representing a sample parsed from a media segment. MediaSamples have `presentationTime()`, `decodeTime()`, and `duration()`, which are used to order these samples relative to one another in a [SampleMap](#samplemap). For codecs which support frame reordering, `presentationTime()` and `decodeTime()` for each sample may differ.

It is probably worth mentioning `MediaTime`, and why we use it instead of `double` for time values..
Comment 3 Peng Liu 2021-12-08 12:38:23 PST 
Comment on attachment 446404 [details]
Patch

I like this patch!

View in context: https://bugs.webkit.org/attachment.cgi?id=446404&action=review

> Source/WebCore/Modules/mediasource/README.md:54
> +

Maybe we can add some information about SourceBufferPrivateAVFObjC and SourceBufferParser?
Comment 4 Jer Noble 2021-12-08 12:43:11 PST 
Created attachment 446412 [details]
Patch for landing
Comment 5 Jer Noble 2021-12-08 12:43:40 PST 
(In reply to Peng Liu from comment #3)
> Comment on attachment 446404 [details]
> Patch
> 
> I like this patch!
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=446404&action=review
> 
> > Source/WebCore/Modules/mediasource/README.md:54
> > +
> 
> Maybe we can add some information about SourceBufferPrivateAVFObjC and
> SourceBufferParser?

Good idea! I'll do that in a follow-up patch.
Comment 6 EWS 2021-12-08 13:40:26 PST 
Committed r286738 (244988@main): <https://commits.webkit.org/244988@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446412 [details].
Comment 7 Radar WebKit Bug Importer 2021-12-08 13:41:21 PST 
<rdar://problem/86227732>
Comment 8 Jer Noble 2021-12-08 14:27:58 PST 
Reopening to attach new patch.
Comment 9 Jer Noble 2021-12-08 14:28:00 PST 
Created attachment 446421 [details]
[fast-cq] Follow-up patch
Comment 10 EWS 2021-12-08 14:38:27 PST 
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Comment 11 Jer Noble 2021-12-08 14:55:45 PST 
Created attachment 446430 [details]
[fast-cq] Follow-up patch
Comment 12 EWS 2021-12-08 14:58:52 PST 
Committed r286742 (244989@main): <https://commits.webkit.org/244989@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446430 [details].