Bug 234025

Summary: [ANGLE] Code generation happens on each build and produces SCM diffs
Product: WebKit Reporter: Dean Jackson <dino>
Component: ANGLEAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dean Jackson
Reported 2021-12-08 12:02:18 PST
[ANGLE] Code generation happens on each build and produces SCM diffs
Attachments
Patch (2.61 KB, patch)
2021-12-08 12:04 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2021-12-08 12:04:49 PST
Created attachment 446403 [details] Patch
EWS Watchlist
Comment 2 2021-12-08 12:06:35 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kimmo Kinnunen
Comment 3 2021-12-08 13:00:48 PST
Comment on attachment 446403 [details] Patch I'd imagine they need to be already checked into repo, as ANGLE doesn't run scripts compile time. I'd also imagine run_code_generation.py could and should be fixed so that the output isn't nondeterministic.
Myles C. Maxfield
Comment 4 2021-12-08 17:37:23 PST
Comment on attachment 446403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446403&action=review > Source/ThirdParty/ANGLE/ChangeLog:14 > + We either need to generate these manually, or fix the Xcode project > + to generate them into Derived Sources so they don't appear in our > + repository. Changing the Xcode project is what https://bugs.webkit.org/show_bug.cgi?id=233990 does.
EWS
Comment 5 2021-12-09 07:34:18 PST
Committed r286779 (245020@main): <https://commits.webkit.org/245020@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446403 [details].
Radar WebKit Bug Importer
Comment 6 2021-12-09 07:35:20 PST
<rdar://problem/86270605>
Note You need to log in before you can comment on or make changes to this bug.