| Summary: | [ANGLE] Code generation happens on each build and produces SCM diffs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | ANGLE | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, mmaxfield, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2021-12-08 12:02:18 PST
Created attachment 446403 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 446403 [details]
Patch
I'd imagine they need to be already checked into repo, as ANGLE doesn't run scripts compile time.
I'd also imagine run_code_generation.py could and should be fixed so that the output isn't nondeterministic.
Comment on attachment 446403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446403&action=review > Source/ThirdParty/ANGLE/ChangeLog:14 > + We either need to generate these manually, or fix the Xcode project > + to generate them into Derived Sources so they don't appear in our > + repository. Changing the Xcode project is what https://bugs.webkit.org/show_bug.cgi?id=233990 does. Committed r286779 (245020@main): <https://commits.webkit.org/245020@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446403 [details]. |