Bug 234024

Summary:

[GPU Process] [Filters] Add the encoding and decoding for SVGFilter

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Layout and Rendering

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, bfulgham, dino, ews-watchlist, fmalita, gyuyoung.kim, kondapallykalyan, pdr, ryuan.choi, schenney, sergio, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

231253, 233989, 234027

Attachments:

Description	Flags
Patch	wenson_hsieh: review+, ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none

Description Said Abou-Hallawa 2021-12-08 11:59:24 PST

This will allow SVGFilter and referenced SVGFilter to be applied in GPUProcess.

Comment 1 Said Abou-Hallawa 2021-12-08 12:17:55 PST

Created attachment 446409 [details]
Patch

Comment 2 Wenson Hsieh 2021-12-08 12:28:15 PST

Comment on attachment 446409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446409&action=review

> Source/WebKit/Platform/IPC/FilterReference.h:334
> +    auto expressionReference = WTF::map(filter.expression(), [&indecies] (auto&& term) -> ExpressionReferenceTerm {

Nit - sp. indecies => indicies

> Source/WebKit/Platform/IPC/FilterReference.h:383
> +    WebCore::SVGFilterExpression expression;

Nit - maybe reserveInitialCapacity here?

Comment 3 Said Abou-Hallawa 2021-12-08 12:39:31 PST

Created attachment 446410 [details]
Patch

Comment 4 Said Abou-Hallawa 2021-12-08 14:37:46 PST

Created attachment 446422 [details]
Patch

Comment 5 EWS 2021-12-08 16:37:40 PST

Committed r286753 (244996@main): <https://commits.webkit.org/244996@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446422 [details].

Comment 6 Radar WebKit Bug Importer 2021-12-08 16:38:25 PST

<rdar://problem/86240715>