Bug 234022

Summary: Prepare for transition to C++20
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, changseok, cmarcelo, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, japhet, jer.noble, keith_miller, kondapallykalyan, mark.lam, mmaxfield, msaboff, pdr, philipj, sbarati, sergio, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233963
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Alex Christensen 2021-12-08 11:31:16 PST
Prepare for transition to C++20
Comment 1 Alex Christensen 2021-12-08 11:38:49 PST
Created attachment 446397 [details]
Patch
Comment 2 Alex Christensen 2021-12-08 16:40:28 PST
Created attachment 446455 [details]
Patch
Comment 3 Yusuke Suzuki 2021-12-09 14:38:28 PST
Comment on attachment 446455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446455&action=review

r=me with one fix.

> Tools/TestWebKitAPI/Tests/WTF/Expected.cpp:-297
> -    NonCopyable(NonCopyable&&) = default;
> -    NonCopyable(const NonCopyable&) = delete;
> -    NonCopyable& operator=(const NonCopyable&) = delete;
> -    NonCopyable& operator=(NonCopyable&&) = default;

We should use `WTF_MAKE_NONCOPYABLE` here to make it noncopyable.
Comment 4 Alex Christensen 2021-12-09 15:11:36 PST
Created attachment 446618 [details]
Patch
Comment 5 Alex Christensen 2021-12-09 15:47:49 PST
Comment on attachment 446618 [details]
Patch

For some reason that didn't compile.  I removed that change from this patch.
Comment 6 Alex Christensen 2021-12-09 16:25:36 PST
http://trac.webkit.org/r286816
Comment 7 Radar WebKit Bug Importer 2021-12-09 16:26:22 PST
<rdar://problem/86296640>