| Summary: | Prepare for transition to C++20 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, changseok, cmarcelo, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, japhet, jer.noble, keith_miller, kondapallykalyan, mark.lam, mmaxfield, msaboff, pdr, philipj, saam, sergio, tzagallo, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=233963 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2021-12-08 11:31:16 PST
Created attachment 446397 [details]
Patch
Created attachment 446455 [details]
Patch
Comment on attachment 446455 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446455&action=review r=me with one fix. > Tools/TestWebKitAPI/Tests/WTF/Expected.cpp:-297 > - NonCopyable(NonCopyable&&) = default; > - NonCopyable(const NonCopyable&) = delete; > - NonCopyable& operator=(const NonCopyable&) = delete; > - NonCopyable& operator=(NonCopyable&&) = default; We should use `WTF_MAKE_NONCOPYABLE` here to make it noncopyable. Created attachment 446618 [details]
Patch
Comment on attachment 446618 [details]
Patch
For some reason that didn't compile. I removed that change from this patch.
|