| Summary: | [Win] WebCore::cfHDropFormat implementation is not CF specific | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||
| Component: | Platform | Assignee: | Don Olmstead <don.olmstead> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 175336 | ||||||||
| Attachments: |
|
||||||||
|
Description
Don Olmstead
2021-12-08 10:57:33 PST
Created attachment 446389 [details]
Patch
Comment on attachment 446389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446389&action=review > Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:56 > +#if USE(CF) > + There is some additional CF specific code in this file that will be removed in a subsequent patch. Comment on attachment 446389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446389&action=review > Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:49 > FORMATETC* cfHDropFormat() Could we rename these to things like "dropFormat"? > Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:737 > void getCFData(IDataObject* data, FORMATETC* format, Vector<String>& dataStrings) ditto > Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:791 > void setCFData(IDataObject* data, FORMATETC* format, const Vector<String>& dataStrings) ditto Comment on attachment 446389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446389&action=review >> Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:49 >> FORMATETC* cfHDropFormat() > > Could we rename these to things like "dropFormat"? This actually corresponds to https://docs.microsoft.com/en-us/windows/win32/shell/clipboard#cf_hdrop so the name does have a specific meaning to Windows code. oh, cool. CFData is not though Created attachment 446395 [details]
Patch
Committed r286708 (244985@main): <https://commits.webkit.org/244985@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446395 [details]. |