Bug 234007 – [libpas] Fix up missing header includes and build guards in unit tests

• Component: New Bugs
• Status: RESOLVED FIXED

[Zan Dobersek]

[libpas] Fix up missing header includes and build guards in unit tests

[Zan Dobersek]

Created attachment 446363 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 446363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446363&action=review

> Source/bmalloc/libpas/src/test/IsoHeapChaosTests.cpp:622
> +#if PAS_OS(DARWIN)
>              for (pthread_t thread : runningThreads) {
>                  kern_return_t result = thread_suspend(pthread_mach_thread_np(thread));
>                  PAS_ASSERT(result == KERN_SUCCESS);
>              }
> +#endif

If we cannot suspend and resume threads, then this test is broken. So you need to disable this test for that platforms.

[Zan Dobersek]

Created attachment 446506 [details]
Patch

Disabled enumerator tests in IsoHeapChaosTests for Linux, due to the missing thread suspension/resuming. Also adjusted inclusions so that they follow the existing order.

[EWS]

Committed r286773 (245014@main): <https://commits.webkit.org/245014@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446506 [details].

[Radar WebKit Bug Importer]

<rdar://problem/86263339>