| Summary: | ANGLE modifies a source file every time you build | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
| Status: | RESOLVED WONTFIX | ||||||
| Severity: | Normal | CC: | ap, dino, emw, ews-watchlist, kbr, kondapallykalyan, kpiddington | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Myles C. Maxfield
2021-12-08 00:05:23 PST
Created attachment 446322 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 446322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446322&action=review > Source/ThirdParty/ANGLE/ChangeLog:20 > + This patch adds a build step to copy all the generation script's input files into > + a DerivedSources/ directory, and copies the script there too, so the script thinks > + its inside the src/ directory, but it's actually not. Then, we can execute the > + script just like normal, except now it's producing a generated file inside the > + DerivedSources/ directory. This patch also adds the generated file to the Xcode > + project (but doesn't check in the file into the repo) so you can see its contents > + while editing, and project-wide searches will find it. This is the same design we > + use for the rest of WebKit's derived sources. The aspect where we copy input files into DerivedSources isn't same design as the rest of WebKit. Is it intended as a temporary hack to overcome generation script's limitations? Comment on attachment 446322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446322&action=review >> Source/ThirdParty/ANGLE/ChangeLog:20 >> + use for the rest of WebKit's derived sources. > > The aspect where we copy input files into DerivedSources isn't same design as the rest of WebKit. Is it intended as a temporary hack to overcome generation script's limitations? Yes. The script has input and output paths hard coded and they both live in src/. So I think the only way to make it work is to copy the necessary files from src/ to DerivedSources/. Closing in favor of https://bugs.webkit.org/show_bug.cgi?id=234025 |