Bug 233982

Summary: Add isMainThread() assertions to specializedChineseLocale
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: Layout and RenderingAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, mattwoodrow, mmaxfield, simon.fraser, webkit-bug-importer, ysuzuki, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 233488    
Attachments:
Description Flags
Patch
mmaxfield: review+
Patch
none
Patch none

Description Cameron McCormack (:heycam) 2021-12-07 22:52:52 PST 
Add isMainThread() assertions to specializedChineseLocale
Comment 1 Cameron McCormack (:heycam) 2021-12-07 22:53:53 PST 
Created attachment 446307 [details]
Patch
Comment 2 Myles C. Maxfield 2021-12-08 21:14:46 PST 
Comment on attachment 446307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446307&action=review

> Source/WebCore/platform/graphics/FontDescription.cpp:103
>  void FontDescription::setSpecifiedLocale(const AtomString& locale)

It looks like this function is exported, but no one outside of WebCore calls it. Can we make it not exported?
Comment 3 Radar WebKit Bug Importer 2021-12-14 22:53:15 PST 
<rdar://problem/86507335>
Comment 4 Matt Woodrow 2022-07-19 15:50:12 PDT 
Created attachment 461023 [details]
Patch
Comment 5 Yusuke Suzuki 2022-07-19 16:49:46 PDT 
BTW, you can use MainThreadNeverDestroyed for NeverDestoryed objects which is available only in MainThread.
Comment 6 Matt Woodrow 2022-07-19 17:31:05 PDT 
Created attachment 461026 [details]
Patch
Comment 7 EWS 2022-07-19 23:03:24 PDT 
Committed 252637@main (5ba8177f9530): <https://commits.webkit.org/252637@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461026 [details].