Bug 233976

Summary: Assert isMainThread() in hasValidAverageCharWidth
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: Layout and RenderingAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, mattwoodrow, mmaxfield, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 233488    
Attachments:
Description Flags
Patch
mmaxfield: review+
Patch none

Description Cameron McCormack (:heycam) 2021-12-07 22:19:43 PST 
.
Comment 1 Cameron McCormack (:heycam) 2021-12-07 22:21:18 PST 
Created attachment 446298 [details]
Patch
Comment 2 Myles C. Maxfield 2021-12-08 21:05:08 PST 
Comment on attachment 446298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446298&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:344
> +    ASSERT(isMainThread());

This is fine, but why not any of the other functions in FontCascade?
Comment 3 Cameron McCormack (:heycam) 2021-12-08 21:09:04 PST 
(In reply to Myles C. Maxfield from comment #2)
> This is fine, but why not any of the other functions in FontCascade?

Because most FontCascade functions are called from worker threads too.
Comment 4 Radar WebKit Bug Importer 2021-12-14 22:20:17 PST 
<rdar://problem/86506432>
Comment 5 Matt Woodrow 2022-07-19 15:48:06 PDT 
Created attachment 461021 [details]
Patch
Comment 6 EWS 2022-07-19 21:58:47 PDT 
Committed 252634@main (4c3c8c892f78): <https://commits.webkit.org/252634@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461021 [details].