Bug 233964

Summary: Avoid noisy Wcomment warnings after ANGLE update in r286603
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: ANGLEAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, dino, don.olmstead, ews-watchlist, gyuyoung.kim, kbr, kkinnunen, kondapallykalyan, mcatanzaro, ryanhaddad, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220896
Attachments:
Description Flags
Patch
none
Patch none

Lauro Moura
Reported 2021-12-07 17:33:40 PST
Avoid noisy Wcomment warnings after ANGLE update in r286603
Attachments
Patch (2.12 KB, patch)
2021-12-07 17:36 PST, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Patch (3.59 KB, patch)
2021-12-08 00:20 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2021-12-07 17:36:24 PST
Created attachment 446268 [details] Patch
EWS Watchlist
Comment 2 2021-12-07 17:37:47 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
EWS
Comment 3 2021-12-07 18:10:49 PST
Committed r286636 (244949@main): <https://commits.webkit.org/244949@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446268 [details].
Radar WebKit Bug Importer
Comment 4 2021-12-07 18:11:51 PST
<rdar://problem/86186455>
Adrian Perez
Comment 5 2021-12-07 23:57:00 PST
I still see a number of similar warnings, at least in RewriteArrayOfArrayOfOpaqueUniforms.cpp and RewriteStructSamplers.cpp; there might be more lurking around if one does a clean build: [269/7571] Building CXX object Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/compiler/translator/tree_ops/RewriteArrayOfArrayOfOpaqueUniforms.cpp.o /app/webkit/Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/RewriteArrayOfArrayOfOpaqueUniforms.cpp:107:1: warning: multi-line comment [-Wcomment] 107 | // / \ | ^ ... [285/7571] Building CXX object Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/compiler/translator/tree_ops/RewriteStructSamplers.cpp.o /app/webkit/Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/RewriteStructSamplers.cpp:169:1: warning: multi-line comment [-Wcomment] 169 | // / \ | ^ ... Wouldn't it have been better to tell CMake to pass -Wno-comment when building ANGLE sources? Also Lauro's patch modifies an ANGLE source file without updating Source/ThirdParty/ANGLE/changes.diff 🤔️ If possible, we should aim to have as little local changes on top of upstream ANGLE as possible.
Adrian Perez
Comment 6 2021-12-08 00:20:52 PST
Created attachment 446324 [details] Patch
Lauro Moura
Comment 7 2021-12-08 07:02:55 PST
(In reply to Adrian Perez from comment #6) > Created attachment 446324 [details] > Patch Testing locally, all good. No warnings (and no changed upstream files... 🙈).
EWS
Comment 8 2021-12-08 09:07:58 PST
Committed r286659 (244972@main): <https://commits.webkit.org/244972@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446324 [details].
Note You need to log in before you can comment on or make changes to this bug.