Bug 233961

Summary: Web Inspector: evaluateScriptForExtension() incorrectly unwraps internal errors
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, drousso, ews-watchlist, inspector-bugzilla-changes, joepeck, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1.0
none
Patch v1.1 - for landing none

Description BJ Burg 2021-12-07 16:56:15 PST
Splitting this change from 233935.
Comment 1 BJ Burg 2021-12-07 16:58:32 PST
<rdar://86123763>
Comment 2 BJ Burg 2021-12-07 22:22:14 PST
Created attachment 446299 [details]
Patch v1.0
Comment 3 Patrick Angle 2021-12-08 13:03:56 PST
Comment on attachment 446299 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=446299&action=review

r=me

> Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.cpp:255
> +                LOG(Inspector, "Internal error encountered while evaluating upon the frontend: at %s:%d:%d: %s", exceptionDetails.sourceURL.utf8().data(), exceptionDetails.lineNumber, exceptionDetails.columnNumber, exceptionDetails.message.utf8().data());

Nit: Odd placement of the first colon IMO... s/`frontend: at`/`frontend at`
Comment 4 BJ Burg 2021-12-08 14:55:38 PST
Created attachment 446429 [details]
Patch v1.1 - for landing
Comment 5 EWS 2021-12-08 16:07:12 PST
Committed r286747 (244992@main): <https://commits.webkit.org/244992@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446429 [details].