Summary: | Web Inspector: evaluateScriptForExtension() incorrectly unwraps internal errors | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, pangle, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
BJ Burg
2021-12-07 16:56:15 PST
Created attachment 446299 [details]
Patch v1.0
Comment on attachment 446299 [details] Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=446299&action=review r=me > Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.cpp:255 > + LOG(Inspector, "Internal error encountered while evaluating upon the frontend: at %s:%d:%d: %s", exceptionDetails.sourceURL.utf8().data(), exceptionDetails.lineNumber, exceptionDetails.columnNumber, exceptionDetails.message.utf8().data()); Nit: Odd placement of the first colon IMO... s/`frontend: at`/`frontend at` Created attachment 446429 [details]
Patch v1.1 - for landing
Committed r286747 (244992@main): <https://commits.webkit.org/244992@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446429 [details]. |