Bug 233959

Summary: Add DOMStructures
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: DOMAssignee: Yusuke Suzuki <ysuzuki>
Status: NEW ---    
Severity: Normal CC: alecflett, annulen, ashvayka, beidson, benjamin, calvaris, cdumez, ews-watchlist, gyuyoung.kim, jsbell, ryuan.choi, sam, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 233918    
Bug Blocks:    
Attachments:
Description Flags
WIP
ews-feeder: commit-queue-
WIP
ews-feeder: commit-queue-
WIP
ews-feeder: commit-queue-
WIP ews-feeder: commit-queue-

Description Yusuke Suzuki 2021-12-07 16:43:32 PST
We should have the same mechanism to DOMConstructors: DOMStructures array.
Now, we have significantly better / faster StructureID implementation. And WriteBarrierStructureID (sizeof(WriteBarrierStructureID) is 4!) is coming.
We should have std::array<WriteBarrierStructureID, numberOfStructures> instead of HashMap<ClassInfo*, WriteBarrier<Structure>>, which is faster. And maybe it is more compact (HashMap allocates roughly 4x memory usually, we do not need to have ClassInfo*, and we do not need to hold Structure*).
Comment 1 Radar WebKit Bug Importer 2021-12-14 16:44:17 PST
<rdar://problem/86496457>
Comment 2 Yusuke Suzuki 2022-02-23 00:31:36 PST
Created attachment 452945 [details]
WIP
Comment 3 Yusuke Suzuki 2022-02-23 01:10:36 PST
Created attachment 452949 [details]
WIP
Comment 4 Yusuke Suzuki 2022-02-23 01:37:55 PST
Created attachment 452951 [details]
WIP
Comment 5 Yusuke Suzuki 2022-02-23 01:58:20 PST
Created attachment 452952 [details]
WIP
Comment 6 Yusuke Suzuki 2024-03-23 18:32:15 PDT
Pull request: https://github.com/WebKit/WebKit/pull/26381