| Summary: | Update ANGLE changes.diff with new roll. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kyle Piddington <kpiddington> | ||||
| Component: | ANGLE | Assignee: | Kyle Piddington <kpiddington> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, ews-watchlist, gman, jonahr, kbr, kkinnunen, kondapallykalyan, kpiddington, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 220896 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Kyle Piddington
2021-12-07 13:49:52 PST
Created attachment 446233 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Gregg, does this patch address your whitespace concerns? Kyle, can you provide a little more background about why this was needed? I thought it should have been handled automatically by the update-angle script during the last roll, and every roll. The mega-roll in question was from Bug 220896. Comment on attachment 446233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446233&action=review This update looks fine to me - let's please work together to upstream as many of the remaining changes as possible, as soon as possible. r+ > Source/ThirdParty/ANGLE/changes.diff:1782 > ++ if (metalDevice.depth24Stencil8PixelFormatSupported && !display->getFeatures().forceD24S8AsUnsupported.enabled) This and some of the other whitespace changes are a bit unfortunate. Can they be cleaned up? Committed r286736 (244987@main): <https://commits.webkit.org/244987@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446233 [details]. |