Bug 233952

Summary: Update ANGLE changes.diff with new roll.
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: ANGLEAssignee: Kyle Piddington <kpiddington>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, gman, jonahr, kbr, kkinnunen, kondapallykalyan, kpiddington, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 220896    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Kyle Piddington
Reported 2021-12-07 13:49:52 PST
Update ANGLE changes.diff with new roll.
Attachments
Patch (137.97 KB, patch)
2021-12-07 13:50 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kyle Piddington
Comment 1 2021-12-07 13:50:22 PST
Created attachment 446233 [details] Patch
EWS Watchlist
Comment 2 2021-12-07 13:51:38 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 3 2021-12-08 12:50:08 PST
Gregg, does this patch address your whitespace concerns? Kyle, can you provide a little more background about why this was needed? I thought it should have been handled automatically by the update-angle script during the last roll, and every roll.
Kenneth Russell
Comment 4 2021-12-08 12:55:34 PST
The mega-roll in question was from Bug 220896.
Kenneth Russell
Comment 5 2021-12-08 13:00:51 PST
Comment on attachment 446233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446233&action=review This update looks fine to me - let's please work together to upstream as many of the remaining changes as possible, as soon as possible. r+ > Source/ThirdParty/ANGLE/changes.diff:1782 > ++ if (metalDevice.depth24Stencil8PixelFormatSupported && !display->getFeatures().forceD24S8AsUnsupported.enabled) This and some of the other whitespace changes are a bit unfortunate. Can they be cleaned up?
EWS
Comment 6 2021-12-08 13:29:58 PST
Committed r286736 (244987@main): <https://commits.webkit.org/244987@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446233 [details].
Radar WebKit Bug Importer
Comment 7 2021-12-08 13:30:30 PST
<rdar://problem/86227239>
Note You need to log in before you can comment on or make changes to this bug.