Bug 233922
| Summary: | [meta] Ensure that no SharedBuffer is modified once returned | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | New Bugs | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | NEW | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 233442, 233923 | ||
| Bug Blocks: | |||
Jean-Yves Avenard [:jya]
Follow-up on bug 233442.
With the SharedBufferBuilder, some code still return a Ref to a SharedBuffer which can then be modified.
Such as PreviewConverter::updateMainResource and the LegacyPreviewLoader which will clear the SharedBuffer after being returned (so any references to that SharedBuffer become useless)
We should eliminate this code pattern and have SharedBufferBuilder::get() always return a new SharedBuffer such as a SharedBuffer is really immutable once created.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/86462307>