Bug 233891

Summary: Remove unneeded virtual allocator methods from Subspace.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 232849    
Attachments:
Description Flags
proposed patch. ysuzuki: review+, ews-feeder: commit-queue-

Mark Lam
Reported 2021-12-06 12:27:39 PST
Since the virtual allocate() and allocateFor() methods are now deleted, we can also rename the inline allocateNonVirtual() and allocatorForNonVirtual() methods to simply allocate() and allocateFor(). Similarly, rename allocatorForNonVirtualConcurrently() to allocatorForConcurrently(). There are 2 places that still invokes the non-inline version of CompleteSubspace::allocatorFor(). For this reason, we introduce a CompleteSubsace::allocatorForNonInline() to keep the linkage the same. There's a chance that the compiler/linker may already inline the method in 1 or both of these places, but we'll offer allocatorForNonInline() to keep the code expressing the same thing and let the compiler/linker decide whether to inline it or not just as before. This is purely a re-factoring patch. There are no behavior changes, except for the removal of those 2 entries from the vtbls.
Attachments
proposed patch. (38.27 KB, patch)
2021-12-06 12:32 PST, Mark Lam 		ysuzuki: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-12-06 12:28:32 PST
<rdar://problem/86117970>
Mark Lam
Comment 2 2021-12-06 12:32:16 PST
Created attachment 446068 [details] proposed patch.
Yusuke Suzuki
Comment 3 2021-12-06 12:43:14 PST
Comment on attachment 446068 [details] proposed patch. r=me
Mark Lam
Comment 4 2021-12-06 14:52:48 PST
Thanks for the review. Landed in r286572: <http://trac.webkit.org/r286572>.
Note You need to log in before you can comment on or make changes to this bug.