| Summary: | Allow WKContentRuleList to run regexes on current frame's URL, not just top frame's URL | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, ews-watchlist, japhet, timothy, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alex Christensen
2021-12-06 11:45:27 PST
Created attachment 446063 [details]
Patch
Created attachment 446607 [details]
Patch
Comment on attachment 446607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446607&action=review > Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:134 > + // FIXME: Do something with this. I might need another bit to indicate whether the conditions are top URL conditions or frameURL conditions, like IfConditionFlag but another bit. No, I think instead the action needs to include whether it had a condition with if-top-url or if-frame-url. Right now we use separate state machines with/without conditions and we either need even more state machines and passes or this. Created attachment 446854 [details]
Patch
Comment on attachment 446854 [details]
Patch
Also not quite there, but getting quite close.
Created attachment 447075 [details]
Patch
Committed r287010 (245215@main): <https://commits.webkit.org/245215@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447075 [details]. |