Bug 233864

Summary: webpushd/webpushtool debugging additions
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1
achristensen: review+
PFL v1
ews-feeder: commit-queue-
PFL v2 none

Brady Eidson
Reported 2021-12-05 21:28:03 PST
webpushd/webpushtool debugging additions Add more debug messages. Add ability for webpushtool to reconnect when connection is lost.
Attachments
Patch v1 (18.66 KB, patch)
2021-12-05 21:49 PST, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
PFL v1 (15.32 KB, patch)
2021-12-06 13:26 PST, Brady Eidson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
PFL v2 (15.33 KB, patch)
2021-12-06 16:09 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2021-12-05 21:49:38 PST
Created attachment 445994 [details] Patch v1
Alex Christensen
Comment 2 2021-12-06 12:42:43 PST
Comment on attachment 445994 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=445994&action=review > Source/WebKit/ChangeLog:14 > + * WebKit.xcodeproj/xcshareddata/xcschemes/webpushd.xcscheme: Added. why? > Source/WebKit/webpushd/PushClientConnection.mm:115 > + messageIdentifier = makeString ("[(0x", hex((uint64_t)(m_xpcConnection.get()), WTF::HexConversionMode::Lowercase), ")] "); reinterpret_cast > Source/WebKit/webpushd/PushClientConnection.mm:117 > + messageIdentifier = makeString ("[", signingIdentifer, " (0x", hex((uint64_t)(m_xpcConnection.get()), WTF::HexConversionMode::Lowercase), ")] "); ditto > Source/WebKit/webpushd/WebPushDaemon.mm:184 > + broadcastDebugMessage((JSC::MessageLevel)0, makeString("New connection: 0x", hex((uint64_t)connection, WTF::HexConversionMode::Lowercase))); JSC::MessageLevel::Log > Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h:39 > +enum class PreferTestService { : bool > Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h:44 > +enum class Reconnect { : bool
Brady Eidson
Comment 3 2021-12-06 13:26:54 PST
Created attachment 446079 [details] PFL v1
Brady Eidson
Comment 4 2021-12-06 13:33:54 PST
The style check failure is a bogus bug because of how the string I'm constructing looks. Bummer.
EWS
Comment 5 2021-12-06 15:50:54 PST
ChangeLog entry in Tools/ChangeLog contains OOPS!.
Brady Eidson
Comment 6 2021-12-06 16:09:44 PST
Created attachment 446090 [details] PFL v2
EWS
Comment 7 2021-12-06 16:38:17 PST
Committed r286579 (?): <https://commits.webkit.org/r286579> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446090 [details].
Radar WebKit Bug Importer
Comment 8 2021-12-06 16:39:25 PST
<rdar://problem/86130115>
Note You need to log in before you can comment on or make changes to this bug.