Bug 233845

Summary:

Add command line `webpushtool` for daemon development and debugging

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
EWS v1	none
EWS v2	thorton: review+
PFL v1	ews-feeder: commit-queue-
PFL v2	ews-feeder: commit-queue-
PFL v3	ews-feeder: commit-queue-
PFL v4	none
PFL v5 (different approach from v4)	ews-feeder: commit-queue-
PFL v6	none

Brady Eidson

Reported 2021-12-03 16:44:28 PST

Add command line `webpushtool` for daemon development and debugging

Attachments
EWS v1 (29.08 KB, patch) 2021-12-03 17:10 PST, Brady Eidson	no flags	Details Formatted Diff Diff
EWS v2 (29.10 KB, patch) 2021-12-03 17:51 PST, Brady Eidson	thorton: review+	Details Formatted Diff Diff
PFL v1 (30.49 KB, patch) 2021-12-03 18:34 PST, Brady Eidson	ews-feeder: commit-queue-	Details Formatted Diff Diff
PFL v2 (30.58 KB, patch) 2021-12-03 18:50 PST, Brady Eidson	ews-feeder: commit-queue-	Details Formatted Diff Diff
PFL v3 (30.59 KB, patch) 2021-12-03 19:51 PST, Brady Eidson	ews-feeder: commit-queue-	Details Formatted Diff Diff
PFL v4 (30.64 KB, patch) 2021-12-03 20:44 PST, Brady Eidson	no flags	Details Formatted Diff Diff
PFL v5 (different approach from v4) (30.63 KB, patch) 2021-12-03 20:55 PST, Brady Eidson	ews-feeder: commit-queue-	Details Formatted Diff Diff
PFL v6 (30.72 KB, patch) 2021-12-03 23:43 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2021-12-03 17:10:59 PST

Created attachment 445928 [details] EWS v1

Tim Horton

Comment 2 2021-12-03 17:20:55 PST

Comment on attachment 445928 [details] EWS v1 View in context: https://bugs.webkit.org/attachment.cgi?id=445928&action=review > Source/WebKit/Configurations/webpushtool.xcconfig:30 > + I think you need to sort out your INSTALL_PATH > Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm:38 > + fprintf(stderr, " --Development Connects to mach service \"org.webkit.webpushtestdaemon.service\" (Default)\n"); Really, leading-capitals in your command line arguments??

Brady Eidson

Comment 3 2021-12-03 17:51:45 PST

Created attachment 445934 [details] EWS v2

Brady Eidson

Comment 4 2021-12-03 18:34:29 PST

Created attachment 445935 [details] PFL v1

Brady Eidson

Comment 5 2021-12-03 18:50:23 PST

Created attachment 445936 [details] PFL v2

Brady Eidson

Comment 6 2021-12-03 19:51:28 PST

Created attachment 445941 [details] PFL v3