| Summary: | Add command line `webpushtool` for daemon development and debugging | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||||||||
| Component: | WebKit Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | thorton, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Brady Eidson
2021-12-03 16:44:28 PST
Created attachment 445928 [details]
EWS v1
Comment on attachment 445928 [details] EWS v1 View in context: https://bugs.webkit.org/attachment.cgi?id=445928&action=review > Source/WebKit/Configurations/webpushtool.xcconfig:30 > + I think you need to sort out your INSTALL_PATH > Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm:38 > + fprintf(stderr, " --Development Connects to mach service \"org.webkit.webpushtestdaemon.service\" (Default)\n"); Really, leading-capitals in your command line arguments?? Created attachment 445934 [details]
EWS v2
Created attachment 445935 [details]
PFL v1
Created attachment 445936 [details]
PFL v2
Created attachment 445941 [details]
PFL v3
Created attachment 445952 [details]
PFL v4
Created attachment 445954 [details]
PFL v5 (different approach from v4)
Created attachment 445962 [details]
PFL v6
Committed r286533 (244865@main): <https://commits.webkit.org/244865@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445962 [details]. |