| Summary: | Extend the scope where the Window's current event is set | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||
| Component: | DOM | Assignee: | Alexey Shvayka <ashvayka> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Trivial | CC: | clopez, ews-watchlist, hi, mkwst, rniwa, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: |
https://github.com/web-platform-tests/wpt/pull/31894 https://bugs.webkit.org/show_bug.cgi?id=248452 |
||||||
| Attachments: |
|
||||||
|
Description
Alexey Shvayka
2021-12-03 11:51:04 PST
Created attachment 445885 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Comment on attachment 445885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445885&action=review > LayoutTests/imported/w3c/ChangeLog:13 > + * web-platform-tests/dom/events/event-global-is-still-set-when-coercing-beforeunload-result-expected.txt: Added. > + * web-platform-tests/dom/events/event-global-is-still-set-when-coercing-beforeunload-result.html: Added. > + * web-platform-tests/dom/events/event-global-set-before-handleEvent-lookup.any-expected.txt: Added. > + * web-platform-tests/dom/events/event-global-set-before-handleEvent-lookup.any.html: Added. > + * web-platform-tests/dom/events/event-global-set-before-handleEvent-lookup.any.js: Added. > + * web-platform-tests/dom/events/resources/event-global-is-still-set-when-coercing-beforeunload-result-frame.html: Added. Are these test getting imported? Or are we adding new tests? Please clarify in the change log. (In reply to Ryosuke Niwa from comment #3) Thank you for review! > Are these test getting imported? Or are we adding new tests? Yea, we are adding new tests. > Please clarify in the change log. Will do. (In reply to Alexey Shvayka from comment #4) > (In reply to Ryosuke Niwa from comment #3) > > Thank you for review! > > > Are these test getting imported? Or are we adding new tests? > > Yea, we are adding new tests. Okay, again, please land WPT change first. Committed r286873 (245103@trunk): <https://commits.webkit.org/245103@trunk> |