Bug 233832

Summary: Make WebLockRegistryProxy::processDidExit() return early if process never registered any locks
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, ggaren, kkinnunen, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 232436    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2021-12-03 11:27:38 PST
Make WebLockRegistryProxy::processDidExit() return early if process never registered any locks. This avoids calling LocalWebLockRegistry::clientsAreGoingAway() (which can be expensive) in the case we know for sure no locks were registered by this process.
Attachments
Patch (2.96 KB, patch)
2021-12-03 11:28 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-12-03 11:28:52 PST
Created attachment 445882 [details] Patch
Alex Christensen
Comment 2 2021-12-03 11:32:08 PST
Wouldn't m_perOriginRegistries be empty? I'm not convinced this does anything.
Chris Dumez
Comment 3 2021-12-03 11:33:35 PST
(In reply to Alex Christensen from comment #2) > Wouldn't m_perOriginRegistries be empty? I'm not convinced this does > anything. Huh? The LocalWebLockRegistry is on the WebsiteDataStore and is thus potentially shared by many WebProcesses. Each WebProcessProxy has its own WebLockRegistryProxy though so I believe this is useful.
Chris Dumez
Comment 4 2021-12-07 11:19:22 PST
Ping review?
EWS
Comment 5 2021-12-07 12:11:15 PST
Committed r286604 (244929@trunk): <https://commits.webkit.org/244929@trunk> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445882 [details].
Radar WebKit Bug Importer
Comment 6 2021-12-07 12:12:48 PST
<rdar://problem/86169856>
Note You need to log in before you can comment on or make changes to this bug.